error in process sentinel: forge--color-brightness: Color doesn’t have #NNNNNN format

[davep]

This seems to have started coinciding with forge updating to forge-20190708.2203 for me. If I forge-pull I get the following error message showing:

forge--color-brightness: Color doesn’t have #NNNNNN format

I modified forge--color-brightness to report the colour it wasn't happy with when throwing the error and, in this case, it's a colour value of "#666".

I'm running against a locally-hosted GitLab and there is such a label colour:

[tarsius]

What is the six digit representation of #666? #606060?

[davep]

I believe so, yes. It's one of the valid formats listed here: https://developer.mozilla.org/en-US/docs/Web/CSS/color_value#RGB_colors

[tarsius]

According to that page it is the same as #666666.

[davep]

Yes, sorry, misread the above. The latter is correct.

[tarsius]

That should do it.

[davep]

Thanks, I'll give it a test very soon.

(error "Color does not have #RRGGBB or #RGB format")

It might be worth noting, from the above link, that something like #6666 is also valid (as is #66666666). For example:

Etc...

[tarsius]

Emacs has some code to determine whether to use the dark or light face definition and given that this is getting more complicated than I originally thought it would probably be better to locate and reuse that than to re-implement it. Maybe you could help me locate it?

[davep]

I don't know of the feature you mention, but if I get some time I'd be happy to have a dig around (which will likely mean trying to better understand what forge is doing here too). Might be a few days I'm afraid as I've got quite a lot on at the moment.

[davep]

Would it be helpful for me to open this as a new issue (that way it should serve as a reminder to me that I need to take a look)?

[tarsius]

I don't know of the feature you mention

Depending on (set-face-foreground 'default THIS) Emacs uses the light or the dark theme. The code that makes that decision based on THIS, might be suitable for our need too, provided it can be called from lisp.

Would it be helpful for me to open this as a new issue

No, but I'll reopen this one if that helps you.

[davep]

Okay, I see. Yes, please reopen and when I get some time I'll dive into this.

[davep]

I've had a brief look and, sadly, it's confirmed that I'm far too ignorant of how faces and fonts and the like work in Emacs to be any help here. Sorry.