for pcase, require at least version 24.1 of Emacs #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sooner or later this had to happen. While I would have preferred to delay this move until after releasing version 2.1.0, it was always clear, that I was only willing to maintain backward compatibility as long as the cost was not very high. Denying myself the use of `pcase' is such a cost. I am going to use this macro a lot, and while it would be possible to implement the things to come without using `pcase', doing so would not be pleasant. So unpleasant in fact, that the temptation would be big to write a specialized "case" macro, similar to `magit-section-case'. But my experience with that, and `magit-section-action', has taught me that going down that road leads to over-specialized abstractions which eventually end up being rather featureful, but never-the-less to restrictive even for its intended use-cases.
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sooner or later this had to happen. While I would have preferred to
delay this move until after releasing version 2.1.0, it was always
clear, that I was only willing to maintain backward compatibility as
long as the cost was not very high.
Denying myself the use of
pcaseis such a cost. I am going to usethis macro a lot, and while it would be possible to implement the
things to come without using
pcase, doing so would not be pleasant.So unpleasant in fact, that the temptation would be big to write a
specialized "case" macro, similar to
magit-section-case. But myexperience with that, and
magit-section-action, has taught me thatgoing down that road leads to over-specialized abstractions which
eventually end up being rather featureful, but never-the-less to
restrictive even for its intended use-cases.