New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive rebase on large repositories is now unusably slow #3519

Closed
drobilla opened this Issue Jul 18, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@drobilla

drobilla commented Jul 18, 2018

At some point in the past couple of months or so (sorry, I haven't narrowed this down more yet), interactively rebasing in magit (from Melpa) has gotten dramatically slower. So much so that I've had to resort to interactive rebasing from the command line.

Magit 20180717.1801, Git 2.14.3 (Apple Git-98), Emacs 25.3.1, darwin

The issue is present with a clean magit-only emacs instance. Before the interactive rebase window finally pops up, emacs is locked up, and the CPU time is all going to git in the command:

/usr/local/bin/git --no-pager --literal-pathspecs -c core.preloadindex=true -c log.showSignature=false branch --remote --contains xxxxxxxxxxx

It's possible something has changed with this particular repository, though the issue occurs for me across various checkout and operating systems (Linux and MacOS). If I run this command manually in a terminal, it also takes a very long time to complete. However, if I do an interactive rebase from the terminal using a different editor, everything is fine.

Trying this command out manually, I've narrowed it down to the --remote option. Without specifying this, the command is a lot faster (still a bit slow, but usable). It looks this this arrived in a7da211

If this functionality is necessary, could perhaps a configuration option be added to disable it?

@tarsius tarsius closed this in 76998b5 Jul 18, 2018

@tarsius

This comment has been minimized.

Show comment
Hide comment
@tarsius

tarsius Jul 18, 2018

Member

I haven't narrowed this down more yet ... It looks this this arrived in a7da211

He said ... and went on to do it 😄

Thanks!

Member

tarsius commented Jul 18, 2018

I haven't narrowed this down more yet ... It looks this this arrived in a7da211

He said ... and went on to do it 😄

Thanks!

@drobilla

This comment has been minimized.

Show comment
Hide comment
@drobilla

drobilla Jul 19, 2018

Yeah, I ended up digging a little more than anticipated when I started writing that :)

Awesome, seems fine now. Thanks!

drobilla commented Jul 19, 2018

Yeah, I ended up digging a little more than anticipated when I started writing that :)

Awesome, seems fine now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment