Magit non-file buffers are not setting list-buffers-directory #355

Closed
mcraveiro opened this Issue Jan 22, 2012 · 1 comment

2 participants

@mcraveiro

If I understood correctly, non-file buffers are expected to set list-buffers-directory in order to give hints as to their "current location". This is useful for instance for modes such as shell toggle [1] and uniquify [2]. However Magit does not seem to be setting this at present. I think it should always be set to the top-level directory of the git repo, but I'm not too sure.

[1] http://www-verimag.imag.fr/~moy/emacs/shell-toggle-patched.el
[2] http://www.gnu.org/software/emacs/manual/html_node/emacs/Uniquify.html

@tarsius
Magit member

No that is not it's purpose

Variable: list-buffers-directory
     This buffer-local variable specifies a string to display in a
     buffer listing where the visited file name would go, for buffers
     that don't have a visited file name.  Dired buffers use this
     variable.

Variable default-directory is close to what you are looking for and it should be set in magit buffers.

@tarsius tarsius closed this Apr 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment