Adding search capabilities to blame info #408

Closed
dudebout opened this Issue May 2, 2012 · 3 comments

2 participants

@dudebout
Magit member

The new magit-blame is really neat.
It would be nice if we could search what it prints, for example to look for a commit number or an author.

@tarsius
Magit member

Yeah, I guess that would be nice but I don't think this can be implemented without major changes. As far as I know you cannot search (the "text in") overlays. I am closing this but of course if you want to work on it yourself feel free to do so - but I am afraid it would require major refactoring. (If you do please also consider showing the blame info in a margin (or better "parallel buffer" because the marin also isn't searchable) and only blame the visible portion of the file).

@tarsius tarsius closed this Oct 21, 2013
@tarsius tarsius reopened this Jan 23, 2014
@tarsius
Magit member

To make this happen we need a completely different implementation. One which inserts the headings as actual text not as overlays. It would then be better to use a new buffer, instead of modifying the file-visiting buffer (or one that visits the file at a revision). Doing it this way has other benefits too.

@tarsius tarsius modified the milestone: 2.1.0, 2.2.0 Feb 22, 2014
@tarsius tarsius modified the milestone: better blame, 2.2.0 Mar 14, 2014
@tarsius tarsius referenced this issue Mar 31, 2014
Closed

Need better support for Git-Blame #1313

12 of 15 tasks complete
@tarsius tarsius modified the milestone: 2.1.0, better blame Mar 31, 2014
@tarsius
Magit member

Closing in favour of #1313.

@tarsius tarsius closed this Mar 31, 2014
@tarsius tarsius added 22 duplicate and removed 11 misc labels Mar 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment