RSA fingerprint question blocks magit #525

Closed
bradwright opened this Issue Jan 7, 2013 · 7 comments

Comments

Projects
None yet
3 participants
Contributor

bradwright commented Jan 7, 2013

If I push to a new server (or in a new VM, more likely), magit gets blocked by the

Are you sure you want to continue connecting (yes/no)? 

message.

tarsius was assigned May 13, 2013

Owner

tarsius commented May 30, 2013

Link to #549 so that I don't forget to look at the other when working on one of them.

tarsius was assigned May 30, 2013

Owner

tarsius commented Jul 20, 2013

I would like to implement this but there is a problem:

The question

Are you sure you want to continue connecting (yes/no)? 

is meaningless on its own. The line before that one is very relevant: it could be "no key on file for this ip" or it could be "key provided by server doesn't match what we have on file". While I might continue in the first case, I will never do so in the second.

I hope someone can compile a list of these strings as presented under different conditions (and also by different client implementations) for me. I don't have the time to do so myself right now.

Contributor

bradwright commented Jul 20, 2013

You're right, it's just the last line of the text that's shown by the minibuffer. In my case it was the "no key on file for this IP" as it was within a new virtual machine.

Contributor

vanicat commented Jul 21, 2013

@jonas: may be we could just show the last printed message to the user and
let him decide.

2013/7/20 Bradley Wright notifications@github.com

You're right, it's just the last line of the text that's shown by the
minibuffer. In my case it was the "no key on file for this IP" as it was
within a new virtual machine.


Reply to this email directly or view it on GitHubhttps://github.com/magit/magit/issues/525#issuecomment-21299348
.

Owner

tarsius commented Aug 2, 2013

@vanicat yes, that's easier and more "portable" :-)

Will do that soon.

Owner

tarsius commented Aug 2, 2013

I have added support for yes-or-no prompts in 2cc379e.

@bradleywright could you please test.

tarsius closed this Aug 2, 2013

Contributor

bradwright commented Aug 2, 2013

👍 works great. Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment