Show more useful information about modified submodules #553

artagnon opened this Issue Feb 7, 2013 · 4 comments


None yet
2 participants

artagnon commented Feb 7, 2013

[Original title: magit-status display breaks when diff.submodule = log]

When diff.submodule = log, the magit-status buffer fails to parse the output of submodule changes properly. As a result, I can't stage/ unstage a submodule change.

@ghost ghost assigned tarsius May 13, 2013

@tarsius tarsius closed this in 6d24680 May 22, 2013


artagnon commented May 23, 2013

This is not a fix; you're side-stepping the issue entirely. I want diff.submodule = log to be rendered properly in magit.


tarsius commented May 24, 2013

That's not fair. You did not mention any feature you want implemented but you did state what breaks. I made it stop breaking, therefore I fixed it.

I am using submodules myself and would also like to see better support. But I cannot read your mind and nothing in your message indicated that it was a feature request.


artagnon commented May 24, 2013

That's alright. What's important is that you now know that it's a good-to-have feature. Write a patch if you like diff.submodule = log, and want to see it in magit.

@tarsius tarsius reopened this May 25, 2013

@tarsius tarsius modified the milestones: 2.1.0, better diff Mar 22, 2014


tarsius commented Mar 29, 2014

Implemented in #1306. This hasn't been merged into master yet.

@tarsius tarsius closed this Mar 29, 2014

@tarsius tarsius removed the 11 diff label May 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment