Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve refs handling #1246

Merged
merged 8 commits into from Feb 22, 2014
Merged

improve refs handling #1246

merged 8 commits into from Feb 22, 2014

Commits on Feb 22, 2014

  1. Copy the full SHA
    8ca0b21 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    7e59cc4 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    4c7e88d View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    4085769 View commit details
    Browse the repository at this point in the history
  5. magit-unambiguous-refname-p: new function

    This replaces `magit-ref-ambiguous-p'; the input isn't
    necessarily a ref and we should assert "the good case".
    tarsius committed Feb 22, 2014
    Copy the full SHA
    34281ba View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    5afdef6 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    318edef View commit details
    Browse the repository at this point in the history
  8. magit-list-interesting-refs: remove function and related crap

    Instead use the recently added `magit-list-refnames'.
    
    This is (only) the starting point to implement more meaningful revision
    and reference completion.  `magit-list-interesting-refs' was very very
    bad.  Basically it and the code which surrounded it (not all of which
    has been replaced yet) took the "when in doubt, pick the worst possible
    option" approach.  E.g. instead of asking "what do we have to complete?"
    and answering that with (in nine out of ten cases) "branches", and then
    going on to "how do we get a list of branches?"; what we actually did
    was "find some git command that gives us a list of refs, pick the first
    one, it doesn't matter whether there are better ones", then start using
    it, notice that the completion candidates contain many refs that we are
    not interested in, implement "filter out the uninteresting refs", and
    then keep on complicating things, making it less and less likely that
    this will ever be fixed.  Well, I have had it, this crap has to go.
    tarsius committed Feb 22, 2014
    Copy the full SHA
    d1d315f View commit details
    Browse the repository at this point in the history