Fix truncated diffstat with binary files #1253

merged 2 commits into from Feb 26, 2014

2 participants


This pull request extends the regular expression of magit-wash-diffstat to support the lines showing changes in binary files. To make it easier on humans to grasp what the regular expression is doing, it is first split into multiple lines in a separate commit.

afrepues added some commits Feb 26, 2014
@afrepues afrepues magit-wash-diffstat: split regex to make it easier on humans
This is just in preparation to make it longer.
@afrepues afrepues magit-wash-diffstat: support binary files
Binary files are displayed with "Bin XXX -> YYY bytes" instead of the
change count and graph. The numbers correspond to the old and new sizes
of the binary file, not lines added/removed, hence the capture groups
for these are left empty and this text left with no special faces.
@tarsius tarsius merged commit c70acae into magit:master Feb 26, 2014

1 check passed

Details default The Travis CI build passed
Magit member


@tarsius tarsius added this to the 2.1.0 milestone Feb 26, 2014
@afrepues afrepues deleted the afrepues:fix/truncated-diffstat-with-binary-files branch Mar 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment