New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use which-function instead of add-log-current-defun #3483

Merged
merged 1 commit into from Jun 18, 2018

Conversation

Projects
None yet
2 participants
@kidd
Contributor

kidd commented Jun 14, 2018

which-function uses add-log-current-defun as one of many helpers so it
should only improve the experience.

I've tried it with lua files and it works good enough. elisp work equally well as before so far.

@tarsius

This comment has been minimized.

Show comment
Hide comment
@tarsius

tarsius Jun 15, 2018

Member

I think which-func has to be required explicitly.

Member

tarsius commented Jun 15, 2018

I think which-func has to be required explicitly.

@kidd

This comment has been minimized.

Show comment
Hide comment
@kidd

kidd Jun 16, 2018

Contributor

oh, you're right... Do you think it makes sense to:

  1. test for (fboundp which-function) and do one thing or the other?
  2. require which-func first
  3. not even worth it
Contributor

kidd commented Jun 16, 2018

oh, you're right... Do you think it makes sense to:

  1. test for (fboundp which-function) and do one thing or the other?
  2. require which-func first
  3. not even worth it
@tarsius

This comment has been minimized.

Show comment
Hide comment
@tarsius

tarsius Jun 16, 2018

Member

Nah, just require it.

Member

tarsius commented Jun 16, 2018

Nah, just require it.

@kidd

This comment has been minimized.

Show comment
Hide comment
@kidd

kidd Jun 16, 2018

Contributor

Done. Thanks!

Btw, how do you usually check if a function has to be required manually or it's already required by default? is emacs -Q the usual way?

Contributor

kidd commented Jun 16, 2018

Done. Thanks!

Btw, how do you usually check if a function has to be required manually or it's already required by default? is emacs -Q the usual way?

Use which-function instead of add-log-current-defun
which-function uses add-log-current-defun as one of many helpers so it
should only improve the experience.

@tarsius tarsius merged commit 2e84b68 into magit:master Jun 18, 2018

@kidd kidd deleted the kidd:use-which-function branch Jun 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment