/magit

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote regexp-meaningful characters in function name #3524

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zvbuhl @tarsius
@zvbuhl
Contributor

zvbuhl commented Jul 25, 2018

This addresses #3523; it resolves a bug in which magit-log-trace-definition doesn't work with Go methods on a pointer receiver (and in general, anything for which which-function returns a string containing a regular expression metacharacter: the issue is that git expects a regular expression).

I was a bit concerned that regexp-quote might not be suited to
escaping the regular expressions git expects, but it appears to do the
right thing: escaping [*.\?+^$ but not (.
@zvbuhl @tarsius
Quote regexp-meaningful characters in function name 
I was a bit concerned that `regexp-quote` might not be suited to
escaping the regular expressions git expects, but it appears to do the
right thing: escaping `[*.\?+^$` but not `(`.

Fixes #3523.
ce9ec52

@tarsius tarsius referenced this pull request Jul 25, 2018

Closed

magit-log-trace-definition doesn't work with Go #3523

@tarsius tarsius merged commit ce9ec52 into magit:master Jul 25, 2018

@tarsius

This comment has been minimized.

Show comment
Hide comment
@tarsius

tarsius Jul 25, 2018

Member

Looks safe enough. Thanks!
Member

tarsius commented Jul 25, 2018

Looks safe enough. Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment