Skip to content
This repository

Pressing "M" shows "Branch manager" instead of "Remote manager" #500

Merged
merged 1 commit into from over 1 year ago

4 participants

Damien Cassou Nicolas Dudebout Moritz Bunkus Yann Hodique
Damien Cassou

Even though the branch manager is actually displayed, it always
confused me that "Branch manager" is shown when I asked for the
"Remote manager".

Signed-off-by: Damien Cassou damien.cassou@gmail.com

Damien Cassou Pressing "M" shows "Branch manager" instead of "Remote manager"
Even though the branch manager is actually displayed, it always
confused me that "Branch manager" is shown when I asked for the
"Remote manager".

Signed-off-by: Damien Cassou <damien.cassou@gmail.com>
2bd614a
Nicolas Dudebout
Collaborator

The "Branch manager" name was here when I started working on it and I have not touched it. Now might be a good time to find it a better/less confusing name. I do not think that calling it two different things in two different locations is a good idea though, it is not very consistent.

Moritz Bunkus

I wrote the original branch manager. Back then it was a pure branch manager, no support for remotes. As it is now it should just be called "Branches & remotes manager" or something similar.

Nicolas Dudebout
Collaborator

Branches & remotes manager captures the essence but is a little lengthy.

Moritz Bunkus

What about simply Braches & Remotes ?

Nicolas Dudebout
Collaborator

Another way of fixing the problem is to merge the two menus given by b and M. The only overlap is with delete and rename but the remote versions could be invoked with an uppercase letter.

Nicolas Dudebout
Collaborator

However, I did not take this approach because R would mean two different things in the popup and the manager:

  • rebase in the manager
  • rename remote in the popup
Yann Hodique sigma merged commit 2bd614a into from January 06, 2013
Yann Hodique sigma closed this January 06, 2013
Damien Cassou DamienCassou deleted the branch January 06, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Showing 1 unique commit by 1 author.

Oct 30, 2012
Damien Cassou Pressing "M" shows "Branch manager" instead of "Remote manager"
Even though the branch manager is actually displayed, it always
confused me that "Branch manager" is shown when I asked for the
"Remote manager".

Signed-off-by: Damien Cassou <damien.cassou@gmail.com>
2bd614a
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 1 deletion. Show diff stats Hide diff stats

  1. 2  magit-key-mode.el
2  magit-key-mode.el
@@ -90,7 +90,7 @@
90 90
     (remoting
91 91
      (man-page "git-remote")
92 92
      (actions
93  
-      ("v" "Branch manager" magit-branch-manager)
  93
+      ("v" "Remote manager" magit-branch-manager)
94 94
       ("a" "Add" magit-add-remote)
95 95
       ("r" "Rename" magit-rename-remote)
96 96
       ("k" "Remove" magit-remove-remote)))
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.