Pressing "M" shows "Branch manager" instead of "Remote manager" #500

Merged
merged 1 commit into from Jan 6, 2013

Projects

None yet

4 participants

@DamienCassou

Even though the branch manager is actually displayed, it always
confused me that "Branch manager" is shown when I asked for the
"Remote manager".

Signed-off-by: Damien Cassou damien.cassou@gmail.com

@DamienCassou DamienCassou Pressing "M" shows "Branch manager" instead of "Remote manager"
Even though the branch manager is actually displayed, it always
confused me that "Branch manager" is shown when I asked for the
"Remote manager".

Signed-off-by: Damien Cassou <damien.cassou@gmail.com>
2bd614a
@dudebout
Member

The "Branch manager" name was here when I started working on it and I have not touched it. Now might be a good time to find it a better/less confusing name. I do not think that calling it two different things in two different locations is a good idea though, it is not very consistent.

@mbunkus
mbunkus commented Oct 30, 2012

I wrote the original branch manager. Back then it was a pure branch manager, no support for remotes. As it is now it should just be called "Branches & remotes manager" or something similar.

@dudebout
Member

Branches & remotes manager captures the essence but is a little lengthy.

@mbunkus
mbunkus commented Oct 30, 2012

What about simply Braches & Remotes ?

@dudebout
Member
dudebout commented Nov 5, 2012

Another way of fixing the problem is to merge the two menus given by b and M. The only overlap is with delete and rename but the remote versions could be invoked with an uppercase letter.

@dudebout
Member
dudebout commented Nov 5, 2012

However, I did not take this approach because R would mean two different things in the popup and the manager:

  • rebase in the manager
  • rename remote in the popup
@sigma sigma merged commit 2bd614a into magit:master Jan 6, 2013
@DamienCassou DamienCassou deleted the DamienCassou:remote-manager-is-named-branch-manager branch Jan 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment