Add support for git-svn --dry-run in magit-svn #563

Merged
merged 3 commits into from Feb 22, 2013

Projects

None yet

2 participants

@legumbre
Contributor

This pull request adds support for the --dry-run switch (-n) in git-svn rebase, dcommit, branch and tag commands. Branching and tagging against a svn repo are one of those somewhat infrequent operations which you really want to get right the first time.

The --dry-run switch allows us to check the magit-process buffer and catch common mistakes when dealing with these commands.

In order to reuse the existing key-mode handling for switches and magit-custom-options, all interactive commands were refactored to use magit-define-command like the rest of magit.

I'm still not done testing the code, comments and feedback welcome!

legumbre added some commits Feb 21, 2013
@legumbre legumbre use magit-define-command for magit-svn-* commands
so that we can use switches and pass them through magit-custom-options
bf0849c
@legumbre legumbre add 'switches key in empty key-mode groups
Modify `magit-key-mode-add-group' so that newly created groups
include the 'switches key by default. This prevents
`magit-key-mode-insert-switch' from failing when trying to add
switches to new groups created at runtime.
63e8e5e
@legumbre legumbre add --dry-run switch (-n) to magit-svn 6377e62
@sigma sigma merged commit 6377e62 into magit:master Feb 22, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment