Make highlighting of current diff hunk customizable. #595

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@dengste

dengste commented Mar 20, 2013

I'm not very fond of the highlighting of the current diff hunk. This commit will make this customizable.

David Engster
Make highlighting of current diff hunk customizable.
(magit-highlight-current-diff-hunk): New variable.
(magit-highlight-section): Only highlight current hunk if above
variable is non-nil.
@sigma

This comment has been minimized.

Show comment Hide comment
@sigma

sigma Apr 2, 2013

Member

I'm wondering, maybe we should make this patch a bit more generic, to be able to prevent arbitrary sections from being highlighted ?

Member

sigma commented Apr 2, 2013

I'm wondering, maybe we should make this patch a bit more generic, to be able to prevent arbitrary sections from being highlighted ?

@tarsius

This comment has been minimized.

Show comment Hide comment
@tarsius

tarsius May 29, 2013

Owner

There is no need for this (the original request), as the same can be achieved by customizing the face. See de7380f.

Owner

tarsius commented May 29, 2013

There is no need for this (the original request), as the same can be achieved by customizing the face. See de7380f.

@tarsius tarsius closed this May 29, 2013

@dengste

This comment has been minimized.

Show comment Hide comment
@dengste

dengste May 29, 2013

This disables highlighting completely. I only want to disable it for diff hunks.

dengste commented May 29, 2013

This disables highlighting completely. I only want to disable it for diff hunks.

@tarsius

This comment has been minimized.

Show comment Hide comment
@tarsius

tarsius May 29, 2013

Owner

Yeah, that's true, so "(the original request)" was misleading :-/

Are you generally happy with the highlighting done my making the text bold now? If not why do you want to keep it elsewhere but not with diff hunks?

I don't really want to add another face. Yet another option would be to change all faces that could be overridden by the highlight to set foreground and the highlight to use the background again. But that I definitely don't want to do because it would cause major pains for users of themes.

Owner

tarsius commented May 29, 2013

Yeah, that's true, so "(the original request)" was misleading :-/

Are you generally happy with the highlighting done my making the text bold now? If not why do you want to keep it elsewhere but not with diff hunks?

I don't really want to add another face. Yet another option would be to change all faces that could be overridden by the highlight to set foreground and the highlight to use the background again. But that I definitely don't want to do because it would cause major pains for users of themes.

@tarsius tarsius added this to the 2.1.0 milestone Feb 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment