DefinedSymbolCollector - Breaks on anonymous classes

[SpacePossum]

$ cd /var/www/my_project
$ php composer-require-checker check composer.json 
ComposerRequireChecker 0.1.4

                                                                                                                                                     
  [UnexpectedValueException]                                                                                                                         
  Given node of type "PhpParser\Node\Stmt\Class_" (defined at line 129)does not have an assigned "namespacedName" property: did you pass it through  
   a name resolver visitor?                                                                                                                          
                                                                                                                                                     

check [--config-file CONFIG-FILE] [--] [<composer-json>]

not sure how to proceed?

This seems to cause the exception; from composer.json

  "autoload": {
    "psr-4": {
      "ProjectName\\": "src"
    }
  },

[Ocramius]

What about the source version?

…

On 23 Jun 2017 2:24 PM, "SpacePossum" ***@***.***> wrote: $ cd /var/www/my_project $ php composer-require-checker check composer.json ComposerRequireChecker 0.1.4 [UnexpectedValueException] Given node of type "PhpParser\Node\Stmt\Class_" (defined at line 129)does not have an assigned "namespacedName" property: did you pass it through a name resolver visitor? check [--config-file CONFIG-FILE] [--] [<composer-json>] not sure how to proceed? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#23>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakPYLuWcDTcpUyk03cPqfBgfMqijrks5sG65fgaJpZM4ODgFI> .

[SpacePossum]

Install through composer.

$ php -v
PHP 7.1.6-1~ubuntu16.04.1+deb.sury.org+1 (cli) (built: Jun  9 2017 08:26:34) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
    with Zend OPcache v7.1.6-1~ubuntu16.04.1+deb.sury.org+1, Copyright (c) 1999-2017, by Zend Technologies
    with Xdebug v2.5.1, Copyright (c) 2002-2017, by Derick Rethans

$ ./vendor/bin/composer-require-checker check  composer.json -vvv
ComposerRequireChecker 1.2.98-63-gd02a3a3-dev

  [UnexpectedValueException]                                                                                                                         
  Given node of type "PhpParser\Node\Stmt\Class_" (defined at line 129)does not have an assigned "namespacedName" property: did you pass it through  
   a name resolver visitor?                                                                                                                          

[Ocramius]

Could you run it with -vvv? I think we simply haven't considered files in the root namespace

…

On 23 Jun 2017 3:47 PM, "SpacePossum" ***@***.***> wrote: Install through composer. $ php -v PHP 7.1.6-1~ubuntu16.04.1+deb.sury.org+1 (cli) (built: Jun 9 2017 08:26:34) ( NTS ) Copyright (c) 1997-2017 The PHP Group Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies with Zend OPcache v7.1.6-1~ubuntu16.04.1+deb.sury.org+1, Copyright (c) 1999-2017, by Zend Technologies with Xdebug v2.5.1, Copyright (c) 2002-2017, by Derick Rethans $ ./vendor/bin/composer-require-checker check composer.json -vvv ComposerRequireChecker 1.2.98-63-gd02a3a3-dev [UnexpectedValueException] Given node of type "PhpParser\Node\Stmt\Class_" (defined at line 129)does not have an assigned "namespacedName" property: did you pass it through a name resolver visitor? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#23 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakNbZxMVsKTGvbZd4bmtOUqlz8LLvks5sG8HagaJpZM4ODgFI> .

[SpacePossum]

$ cd /var/www/my_project
$ ./vendor/bin/composer-require-checker check composer.json  -vvv
ComposerRequireChecker 1.2.98-63-gd02a3a3-dev


  [UnexpectedValueException]
  Given node of type "PhpParser\Node\Stmt\Class_" (defined at line 129)does not have an assigned "namespacedName" property: did you pass it through
   a name resolver visitor?


Exception trace:
 () at /var/www/my_project/vendor/maglnet/composer-require-checker/src/ComposerRequireChecker/NodeVisitor/DefinedSymbolCollector.php:94
 ComposerRequireChecker\NodeVisitor\DefinedSymbolCollector->recordDefinitionOf() at /var/www/my_project/vendor/maglnet/composer-require-checker/src/ComposerRequireChecker/NodeVisitor/DefinedSymbolCollector.php:52
 ComposerRequireChecker\NodeVisitor\DefinedSymbolCollector->recordClassDefinition() at /var/www/my_project/vendor/maglnet/composer-require-checker/src/ComposerRequireChecker/NodeVisitor/DefinedSymbolCollector.php:42
 ComposerRequireChecker\NodeVisitor\DefinedSymbolCollector->enterNode() at /var/www/my_project/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:108
 PhpParser\NodeTraverser->traverseNode() at /var/www/my_project/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:120
 PhpParser\NodeTraverser->traverseNode() at /var/www/my_project/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:171
 PhpParser\NodeTraverser->traverseArray() at /var/www/my_project/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:101
 PhpParser\NodeTraverser->traverseNode() at /var/www/my_project/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:171
 PhpParser\NodeTraverser->traverseArray() at /var/www/my_project/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:101
 PhpParser\NodeTraverser->traverseNode() at /var/www/my_project/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:171
 PhpParser\NodeTraverser->traverseArray() at /var/www/my_project/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:101
 PhpParser\NodeTraverser->traverseNode() at /var/www/my_project/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:171
 PhpParser\NodeTraverser->traverseArray() at /var/www/my_project/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:101
 PhpParser\NodeTraverser->traverseNode() at /var/www/my_project/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:171
 PhpParser\NodeTraverser->traverseArray() at /var/www/my_project/vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php:85
 PhpParser\NodeTraverser->traverse() at /var/www/my_project/vendor/maglnet/composer-require-checker/src/ComposerRequireChecker/DefinedSymbolsLocator/LocateDefinedSymbolsFromASTRoots.php:29
 ComposerRequireChecker\DefinedSymbolsLocator\LocateDefinedSymbolsFromASTRoots->__invoke() at /var/www/my_project/vendor/maglnet/composer-require-checker/src/ComposerRequireChecker/Cli/CheckCommand.php:72
 ComposerRequireChecker\Cli\CheckCommand->execute() at /var/www/my_project/vendor/symfony/console/Command/Command.php:264
 Symfony\Component\Console\Command\Command->run() at /var/www/my_project/vendor/symfony/console/Application.php:835
 Symfony\Component\Console\Application->doRunCommand() at /var/www/my_project/vendor/symfony/console/Application.php:200
 Symfony\Component\Console\Application->doRun() at /var/www/my_project/vendor/symfony/console/Application.php:124
 Symfony\Component\Console\Application->run() at /var/www/my_project/vendor/maglnet/composer-require-checker/bin/composer-require-checker.php:32
 include() at /var/www/my_project/vendor/maglnet/composer-require-checker/bin/composer-require-checker:3

check [--config-file CONFIG-FILE] [--] [<composer-json>]

maybe I can have a look into this later on, let me know if I can provide more useful data :)

[Ocramius]

@SpacePossum I think we'd need to know the offending file here: was hoping to see such information in the trace :-\

[SpacePossum]

I pinned it down to anonymous class, for example;

namespace MyProject\CLI\Commands;

abstract class AbstractCommand extends Command
{
    public function execute(InputInterface $input, OutputInterface $output)
    {
//        $ended = new class() {
//            public $controlledEnd = false;
//        };

         // ...
    }

I'll try to come up with utest and fix PR when I find the time :)

[Ocramius]

Aha, that's a nasty one indeed :-)

Thanks for pinning it down - wouldn't be able to do so otherwise.

I guess it's something around

ComposerRequireChecker/test/ComposerRequireCheckerTest/DefinedSymbolsLocator/LocateDefinedSymbolsFromASTRootsTest.php

Lines 32 to 44 in 7768b06

	public function testBasicLocate()
	{
	$roots = [
	[new Class_('MyClassA'), new Class_('MyClassB')],
	[new Class_('MyClassC')],
	];
	$symbols = $this->locate([$roots]);
	$this->assertContains('MyClassA', $symbols);
	$this->assertContains('MyClassB', $symbols);
	$this->assertContains('MyClassC', $symbols);
	}

[SpacePossum]

thanks for the pointer @Ocramius , is a good help 👍

[weirdan]

Would love to see this released.