Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): OVS packages are upgraded in magma_dev VM #13487

Merged
merged 3 commits into from
Aug 4, 2022
Merged

chore(ci): OVS packages are upgraded in magma_dev VM #13487

merged 3 commits into from
Aug 4, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Aug 3, 2022 •
edited
Loading

Summary

  • A new magma_dev image was created based on the image 1.1.20210618
    • The VM was created with the Packer file
      orc8r/tools/packer/magma-focal-virtualbox-patch-upgrade-ovs-1.1.20210618.json
    • The version of the OVS packages is upgraded to 2.15.4-9-magma
    • The Vagrant file and GitHub actions cache keys are adapted accordingly

Test Plan

Additional Information

  • This change is backwards-breaking

@LKreutzer
chore(ci): Update OVS packages in magma_dev VM
20c3545 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer
chore(ci): Update cache keys for GitHub actions
ffc157a 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer
chore(ci): Update magma_dev box version in Vagrantfile
795f4c4 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Aug 3, 2022
@LKreutzer LKreutzer self-assigned this Aug 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Aug 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 795f4c4.

@LKreutzer LKreutzer changed the title New magma dev mitigation chore(ci): OVS packages are upgraded in magma_dev VM Aug 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

dp-workflow

14 tests   14 ✔️  3m 39s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 795f4c4.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

cloud-workflow

1 000 tests   1 000 ✔️  3m 2s ⏱️
   356 suites         0 💤
       7 files           0 ❌

Results for commit 795f4c4.

@LKreutzer LKreutzer marked this pull request as ready for review August 3, 2022 14:59
@LKreutzer LKreutzer requested a review from a team as a code owner August 3, 2022 14:59
@LKreutzer LKreutzer requested a review from a team August 3, 2022 14:59
@LKreutzer LKreutzer requested a review from a team as a code owner August 3, 2022 14:59
@LKreutzer LKreutzer requested review from sebathomas, mattymo and maxhbr and removed request for mattymo August 3, 2022 14:59
sebathomas
sebathomas approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@sebathomas sebathomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, let's wait for the CI signals from build and integ tests.

maxhbr
maxhbr approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magma magma deleted a comment from github-actions bot Aug 3, 2022
@maxhbr maxhbr requested a review from Neudrino August 3, 2022 15:15
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

agw-workflow

615 tests   611 ✔️  3m 50s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 795f4c4.

@LKreutzer
Copy link
Contributor Author

More LTE integ test (bazel) runs:

@LKreutzer LKreutzer merged commit 86ec0a5 into magma:master Aug 4, 2022
@LKreutzer LKreutzer mentioned this pull request Aug 4, 2022
Merged
6 tasks
emakeev pushed a commit to emakeev/magma that referenced this pull request Aug 5, 2022
@LKreutzer @emakeev
chore(ci): OVS packages are upgraded in magma_dev VM (magma#13487)
43d19f2 
* chore(ci): Update OVS packages in magma_dev VM

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

* chore(ci): Update cache keys for GitHub actions

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

* chore(ci): Update magma_dev box version in Vagrantfile

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhbr maxhbr maxhbr approved these changes

@sebathomas sebathomas sebathomas approved these changes

@Neudrino Neudrino Awaiting requested review from Neudrino

Assignees

@LKreutzer LKreutzer

Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LKreutzer @maxhbr @Neudrino @sebathomas