Skip to content

[NMS] Add Gateway create and edit #2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karthiksubraveti merged 1 commit into from
Jul 27, 2020
Merged

[NMS] Add Gateway create and edit #2009

karthiksubraveti merged 1 commit into from
Jul 27, 2020

Conversation

@HannaFar
Copy link
Contributor

@HannaFar HannaFar commented Jul 21, 2020 •
edited
Loading

@HannaFar HannaFar marked this pull request as draft July 21, 2020 20:35
@HannaFar HannaFar force-pushed the nms/GatewayCreation branch from 1620570 to 3caaf87 Compare July 21, 2020 20:42
@karthiksubraveti
Copy link
Contributor

karthiksubraveti commented Jul 21, 2020 •
edited
Loading

One thing i realized when making subscription related provisioning pages is that sometimes we have to propagate the state all the way upto Overview page. For e.g. We currently have this bug in enodeb provisioning where detailed pages get updated but top overview page doesn't get updated.
So in subscriber provisioning i ended using context for holding state and using set methods to propagate state up all the way to the top. In future, we could clean this up with better state management methods i believe.

out

@HannaFar HannaFar force-pushed the nms/GatewayCreation branch from 3caaf87 to c945934 Compare July 23, 2020 22:36
@HannaFar HannaFar marked this pull request as ready for review July 23, 2020 22:37
@HannaFar HannaFar force-pushed the nms/GatewayCreation branch 6 times, most recently from 78cb268 to 645b60c Compare July 24, 2020 00:08
karthiksubraveti
karthiksubraveti approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@karthiksubraveti karthiksubraveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. If possible please post a screen recording of the changes. You can convert mov to gif and attach it to the review. Thanks

facebook-github-bot
facebook-github-bot reviewed Jul 24, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karthiksubraveti has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@119Vik
Copy link
Contributor

119Vik commented Jul 25, 2020

Can one of the admins verify this patch?

@karthiksubraveti
Copy link
Contributor

karthiksubraveti commented Jul 25, 2020

@HannaFar the copyright information recently changed and that's causing eslint failure. Can you update this. We can merge the change after this

@HannaFar HannaFar force-pushed the nms/GatewayCreation branch from f00e242 to 76193c2 Compare July 27, 2020 10:55
@HannaFar HannaFar requested a review from xjtian as a code owner July 27, 2020 10:55
@HannaFar
Add Gateway create and edit
ed3db37 
Signed-off-by: HannaFar <hannafarag159@gmail.com>
@HannaFar HannaFar force-pushed the nms/GatewayCreation branch from 76193c2 to ed3db37 Compare July 27, 2020 11:12
@karthiksubraveti karthiksubraveti merged commit f12afa3 into magma:master Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@andreilee andreilee Awaiting requested review from andreilee

@xjtian xjtian Awaiting requested review from xjtian

+1 more reviewer

@karthiksubraveti karthiksubraveti karthiksubraveti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HannaFar @karthiksubraveti @119Vik @facebook-github-bot @mamga-docusaurus-bot