Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #108] Sync indentation of threading forms with Clojure #109

Merged
merged 1 commit into from Dec 20, 2014

Conversation

bbatsov
Copy link
Contributor

@bbatsov bbatsov commented Dec 20, 2014

No description provided.

@magnars
Copy link
Owner

magnars commented Dec 20, 2014

I'm not convinced that emacs lisp needs to follow clojures' lead on this.

@bbatsov
Copy link
Contributor Author

bbatsov commented Dec 20, 2014

@magnars It's a Clojure construct after all and it has the same semantics. I find it odd to have the same thing with the same semantics indented in a different way. As I said already, I'm personally fond of this indentation, but I'm even fonder of consistency and I'd like this to behave similarly in both languages.

@magnars
Copy link
Owner

magnars commented Dec 20, 2014

I'm not sure consistency with clojure-mode is a goal for dash. This is hardly the sole difference between the two languages and modes. We've used this indentation for the threading macros the last two years - out of sync with clojure-mode the entire time (apart from a brief, but wonderful, moment in time. ;-)) Changing it just to get in line with how Clojure is indented seems entirely needless to me.

@bbatsov
Copy link
Contributor Author

bbatsov commented Dec 20, 2014

This is hardly the sole difference between the two languages and modes.

It's one of very few differences actually (regarding indentation - probably only cond and if). After I took over clojure-mode I've tried to align it with emacs-lisp-mode and lisp-mode. Yesterday's indentation drama reminded me of this goal. :-)

I can only assume that a lot of the people using threading macros in Emacs Lisp have done some Clojure, so aligning the indentation in both contexts might reduce the cognitive burden on them.

That's ultimately your call, of course.

@magnars
Copy link
Owner

magnars commented Dec 20, 2014

It's one of very few differences actually (regarding indentation - probably only cond and if). After I took over clojure-mode I've tried to align it with emacs-lisp-mode and lisp-mode.

Oh, well done. This changes my outlook on the issue quite a bit. Let's go for it.

magnars added a commit that referenced this pull request Dec 20, 2014
[Fix #108] Sync indentation of threading forms with Clojure
@magnars magnars merged commit afe2781 into magnars:master Dec 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants