Fix text-mode, c-mode and org-mode on recent Emacsen #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Emacs 24.4, er/mark-defun is managing to expand the region in org-mode buffers. This isn't useful, and required the user to call expand-region again to further expand the region to semantically meaningful org region. Instead, we exclude er/mark-defun in org-mode buffers.
text-mode.el does not end with a call to provide, so there's no feature 'text-mode that we can load. As a result, text-mode-expansions was never loaded.
In Emacs 25.1, `save-excursion` does not save the mark, we need to use `save-mark-and-excursion`. As a result, `er/c-mark-statement` was never marking a region.
Wilfred
force-pushed
the
better_tests
branch
from
2fdbefb
to
799b94c
Compare
Wilfred
changed the title
|
Thanks! |
pesterhazy
added a commit
to pesterhazy/expand-region.el
that referenced
this pull request
Jul 28, 2022
After upgrading from Emacs 27 to 28.1, loading expand-region breaks with the error message "Wrong type argument: stringp, (require . package)" This is due to using eval-after-load with a string argument. This odd call style was introduced in magnars#213 However, the assertion that text-mode is missing a provide call hasn't been true in 6 years: emacs-mirror/emacs@f70f9a5
magnars
pushed a commit
that referenced
this pull request
Jul 29, 2022
After upgrading from Emacs 27 to 28.1, loading expand-region breaks with the error message "Wrong type argument: stringp, (require . package)" This is due to using eval-after-load with a string argument. This odd call style was introduced in #213 However, the assertion that text-mode is missing a provide call hasn't been true in 6 years: emacs-mirror/emacs@f70f9a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes:
and ensures we test against Emacs 24.3 up to 25.1, plus trunk.