Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormSpring valid() #1725

Closed
loverszhaokai opened this issue Sep 1, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@loverszhaokai
Copy link
Contributor

commented Sep 1, 2015

  1. The original test vector of FormSpring:
static struct fmt_tests formspring_tests[] = {
    {"2a4fa0bf8c6a01dd625d3141746451ba51e07f99dc9143f1e25a37f65cb02eb4$RA", "test1"},
    // repeat in the same format that is used in john.pot
    {"$dynamic_61$2a4fa0bf8c6a01dd625d3141746451ba51e07f99dc9143f1e25a37f65cb02eb4$RA", "test1"},
    {NULL}
};

You can see that the difference between the first and the second test vector is the "$dynamic_61$".

When I add the following test vector, the self-test passed.

{"$dynamic_61$a987090ac31f466c4637e22858aa3db0001e7c0ad8e6724e26e76b8e531df46c$76931fac", "abc"}

But the self-test failed when I tried to add "$dynamic_61$" before the hash:

{"a987090ac31f466c4637e22858aa3db0001e7c0ad8e6724e26e76b8e531df46c$76931fac", "abc"},
$ ./john --test=0 --format=FormSpring
Testing: FormSpring [sha256($s.$p) 256/256 AVX2 8x]... FAILED (valid (a987090ac31f466c4637e22858aa3db0001e7c0ad8e6724e26e76b8e531df46c$76931fac))

Is this a bug ?

@magnumripper

This comment has been minimized.

Copy link
Owner

commented Sep 1, 2015

I see now formspring defines SALT_SIZE as 2. Doesn't look like a bug to me, your test vector simply didn't fit the format.

@jfoug

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2015

c5fea65 2 byte salt now honored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.