output script to create land and nitrogen inputs for LPJmL #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emolinab
previously approved these changes
Jul 22, 2020
emolinab
reviewed
Jul 22, 2020
| print("generating INMS output for the run: ") | ||
| print(title) | ||
|
|
||
| filename=paste0(outputdir,"report_",title,".mif") |
There was a problem hiding this comment.
This is a little thing but you have a few "=" instead of the common "<-" . Also, I don't see where this "filename" variable is used in.
emolinab
requested changes
Jul 23, 2020
deleted filename
added newline at the end of the file
emolinab
approved these changes
Aug 14, 2020
k4rst3ns
reviewed
Aug 14, 2020
| untar(tarfile = tgz, files = "lpj_yields_0.5.mz", exdir=outputdir) | ||
|
|
||
| print("create an separate output directory for cellular results") | ||
| outputpath<-paste0("./output/",title,"/") |
There was a problem hiding this comment.
Just a question: Why this will be a seperate output dir?
Seems to be like the normal naming convention for runs (without the time tag), but maybe I oversee something. If not:
- Doesn't it makes sense to store the created output together with the fulldata.gdx and the config.log for more transparency?
- And if not possible, could the outputpath have a reference in the name for being cellular output to a specific outputdir? (paste0(title,"_cellular") or something like that).
At the moment I am afraid, we might lose a bit track about which cellular postprocessed data belongs to which run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.