Contruction wood dev and new release needed for forestry paper

[abhimishr]

🐦 Purpose of this PR 🐦

This PR brings the construction wood code development + work done for forestry paper to the main develop branch. These changes are needed to have an intermediate release of the model for submission of the forestry paper (https://doi.org/10.5194/gmd-2021-76)

🔧 Checklist for PR creator 🔧

• Labeling pull request correctly from the label list.

• Low risk : Simple bugfixes (missing files, updated documentation, typos) or Start/output scripts
• Medium risk : New realization / Changes to existing realization / Other changes which don't modify default.cfg
• High risk : New input files (if cfg$input is changed in default.cfg) / Modification to core model (eg. changes in equations, calculations, introduction of new sets etc.) / Other changes in default.cfg

• Providing additional information based on PR label

• Low risk : No new model run needed.
• Medium risk : Default run based on the current version of the fork from which PR is made
• High risk
  • Default run from the current develop branch
  • Default run based on the current version of the fork from which PR is made

• 📉 Performance loss/gain from current default behavior 📈

  • Current develop branch default :37m51s
  • This PR's default : 30m52s

• Added changes to CHANGELOG.md

• Compilation check (model starts without compilation errors - use gams main.gms action=c in model folder for testing).

• No hard coded numbers and cluster/country/region names.

• The new code doesn't contain declared but unused parameters or variables.

• Where relevant, In-code comments added including documentation comments.

• Made sure that documentation created with goxygen is okay (use goxygen::goxygen() for testing).

• Changes to magpie4 R library for post processing of model output (ideally backward compatible).

• Self-review of my own code.

• For high risk runs: validation of major model indicators - Land-use, emissions, food prices, Tau. %Delete this line in case it is not a high risk run%

⚠️ Additional notes or warnings ⚠️

🚨 Checklist for RSE reviewer 🚨

• PR is labeled correctly.
• CHANGELOG is updated correctly
• No hard coded numbers and cluster/country/region names.
• No unnecessary increase in module interfaces
• All required updates in interfaces (if any) have been properly adressed in the module contracts
• In-code comments and documentation comments are satisfactory.
• model behavior/performance is satisfactory.
• Requested changes (if any) were applied correctly

🚨 Checklist for MAgPIE reviewer 🚨

• PR is labeled correctly.
• CHANGELOG is updated correctly
• No hard coded numbers and cluster/country/region names.
• Changes to the model are scientifically sound
• In-code comments and documentation comments are satisfactory.
• model behavior/performance is satisfactory.
• Requested changes (if any) were applied correctly

[tscheypidi]

just the minor comment to please not commit out-commented code. Besides that it looks ok from RSE side

[tscheypidi]

please avoid committing out-commented code. Include it with a switch instead if it should be optional

[abhimishr]

Removed unused code

[tscheypidi]

please avoid committing out-commented code. Include it with a switch instead if it should be optional

[abhimishr]

Removed unused code

[flohump]

Overall fine. Some minor changes are needed, which do not affect the model outcome.