-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced config.log and config.Rdata with config.yml #368
Conversation
* removed confidential information from config before storing it in config.yml
@@ -7,7 +7,7 @@ | |||
|
|||
scalars | |||
|
|||
s42_watdem_nonagr_scenario Scenario for non agricultural water demand from WATERGAP (1) / 1 / | |||
s42_watdem_nonagr_scenario Scenario for non agricultural water demand from WATERGAP (1) / 2 / |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it have any effect for users that this parameter changed from 1 to 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch. No, it does not have an effect. It seems that there was just an inconsistency between the setting GAMS and in default.cfg. Now both show the same value (2).
@@ -12,6 +12,7 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just caught my eye but not related to this PR: The name of this file is missing a "t" in "exising".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed as well
🐦 Purpose of this PR 🐦
This PR improves the handling of settings in the model output folder. Instead of 2 files (a machine readable config.Rdata and a human readable config.log) we have now one unified file which serves both purposes.
🔧 Checklist for PR creator 🔧
📉 Performance loss/gain from current default behavior 📈
Added changes to
CHANGELOG.md
Compilation check (model starts without compilation errors - use
gams main.gms action=c
in model folder for testing).No hard coded numbers and cluster/country/region names.
The new code doesn't contain declared but unused parameters or variables.
Where relevant, In-code comments added including documentation comments.
Made sure that documentation created with
goxygen
is okay (usegoxygen::goxygen()
for testing).Changes to
magpie4
R library for post processing of model output (ideally backward compatible).Self-review of my own code.
For high risk runs: validation of major model indicators - Land-use, emissions, food prices, Tau. %Delete this line in case it is not a high risk run%
NA
🚨 Checklist for RSE reviewer 🚨
CHANGELOG
is updated correctly🚨 Checklist for MAgPIE reviewer 🚨
CHANGELOG
is updated correctly