New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query_directory function fix #102

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Extravert-ir

Extravert-ir commented Jul 29, 2018

Masks with * as beginning character were incorrectly handled: *whatever mask was treated like * and returned whole directory contents.

@maharmstone

This comment has been minimized.

Show comment
Hide comment
@maharmstone

maharmstone Jul 29, 2018

Owner

Where have you seen this behaviour? The command prompt works as expected for me.

Owner

maharmstone commented Jul 29, 2018

Where have you seen this behaviour? The command prompt works as expected for me.

@Extravert-ir

This comment has been minimized.

Show comment
Hide comment
@Extravert-ir

Extravert-ir Jul 29, 2018

Firstly, I've encountered this when tested ReactOS booting from btrfs partition using your driver.
NtQueryDirectoryFile returned wrong results, here is a small test program: https://gist.github.com/Extravert-ir/6617e8019013363a2d972aad231eab9e
But it can simply be tested with dir:
btrfs_bug
The contents of folders are identical, C: is NTFS drive, E: is BTRFS drive

Extravert-ir commented Jul 29, 2018

Firstly, I've encountered this when tested ReactOS booting from btrfs partition using your driver.
NtQueryDirectoryFile returned wrong results, here is a small test program: https://gist.github.com/Extravert-ir/6617e8019013363a2d972aad231eab9e
But it can simply be tested with dir:
btrfs_bug
The contents of folders are identical, C: is NTFS drive, E: is BTRFS drive

@maharmstone

This comment has been minimized.

Show comment
Hide comment
@maharmstone

maharmstone Jul 30, 2018

Owner

Oh, you're quite right! Thank you for fixing this. I'll accept the patch when I get a decent Internet connexion.

I found your article interesting - that was some good work. I'm very surprised that this was the only bug of mine that you needed to fix!

Owner

maharmstone commented Jul 30, 2018

Oh, you're quite right! Thank you for fixing this. I'll accept the patch when I get a decent Internet connexion.

I found your article interesting - that was some good work. I'm very surprised that this was the only bug of mine that you needed to fix!

@HBelusca HBelusca referenced this pull request Aug 14, 2018

Open

Boot Windows? #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment