Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to disable mutual exclusivity? #15

Closed
qinghezeng opened this issue Oct 2, 2020 · 4 comments
Closed

How to disable mutual exclusivity? #15

qinghezeng opened this issue Oct 2, 2020 · 4 comments

Comments

@qinghezeng
Copy link

Hi, I am trying to apply CLAM to a multi-class problem. For my data, the label classes are more like predicting cancer grades. Is it possible to remove the mutual exclusivity? Thank you!

@fedshyvana
Copy link
Collaborator

Hi, yes, it's would not be enabled as long as you don't use --subtyping.

@qinghezeng
Copy link
Author

Thank you for your answer!
There is one more thing confusing me. For sub-typing problem, for example, in main.py line 174:

    if args.model_type == 'clam':
        assert args.subtyping

Does it mean the --subtyping flag must be used? However, in line 95:

parser.add_argument('--model_type', type=str, choices=['clam_sb', 'clam_mb', 'mil'], default='clam_sb', 
                    help='type of model (default: clam_sb, clam w/ single attention branch)')

We can see 'clam' option is not accepted for --model_type. So why do we need this?

@fedshyvana
Copy link
Collaborator

Hi, sorry for the confusion, first of all: the assertion statement is just for my own book-keeping i.e. i wanted to use subtyping for that specific task I defined and wanted to make sure that when I was training with that task, i would not forget to enable it. So no, you do not have to use the subtyping flag for any specific task depending on your needs. second of all: 'clam' is just something i forgot to update in the code ('clam_sb' and 'clam_mb' used to be a single option called 'clam') - i will correct that shortly, thanks for pointing out.

@qinghezeng
Copy link
Author

Thank you so much for your detailed explanation!!

scjjb added a commit to scjjb/CLAM that referenced this issue May 19, 2022
Remove reference to model_type 'clam', which is no longer functional, as explained in mahmoodlab#15.
SpaceQuark pushed a commit to SpaceQuark/CLAM that referenced this issue May 4, 2024
Remove reference to model_type 'clam', which is no longer functional, as explained in mahmoodlab#15.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants