Conversation
|
Wow! Thank you! Unfortunately, as it stands, I see many issues with this code. The interface is correct, but there are many antipatterns in play that would hurt immediate usability, as well as long-term maintainability. Please see my comments inline. Overall a good effort, though, and if you make the changes in future PRs, your code is sure to be accepted! Thanks again! |
There was a problem hiding this comment.
This appears to be an unused import, and while built-in, can set the wrong expectation for the following code.
There was a problem hiding this comment.
Unlike Java and C++, class instance members do not need class-level declarations. extension is a true class-level attribute, but this attribute is destined to be overridden in __init__. This line should be removed.
NB: This is a staged pull request, full of bad code (hence the branch name), so that we can see how some Python antipatterns manifest. I'll be playing the part of both the submitter and the reviewer, but the submitter (starting with the message following the italics) will write in quotes.
"I really like the LineDAL's JSONLines approach, and saw there was a stubbed out version of a SQLite implementation, so I am submitting this proposed implementation. I'm new to Python, so please let me know what you think."