Skip to content
This repository has been archived by the owner on Nov 15, 2019. It is now read-only.

Updated to work with libc 0.2 #24

Merged
merged 2 commits into from Jun 2, 2016
Merged

Conversation

dhylands
Copy link
Contributor

@dhylands dhylands commented May 30, 2016

This change is Reviewable

@maidsafe-highfive
Copy link

Thanks for the pull request, and welcome! The MaidSafe team is excited to review your changes, and you should hear from @canndrew (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTOR.md for more information.

@ustulation
Copy link
Contributor

hey @dhylands - thanks for the PR. It fails Windows CI currently. Can you pls see if you can sort that ? Should be good for review after that.

@dhylands
Copy link
Contributor Author

Added a commit to address the Windows side of things. I don't have any IPv6 equipment to test things, so it would be good to take special attention to this change (from a review perspective):
23632fd#diff-b4aea3e418ccdb71239b96952d9cddb6L163 and this change: 6c8df39#diff-b4aea3e418ccdb71239b96952d9cddb6L361

My understanding is that those are stored in network (big-endian) order, so I'm pretty sure I rewrote it correctly.

@canndrew
Copy link
Contributor

canndrew commented Jun 2, 2016

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@canndrew
Copy link
Contributor

canndrew commented Jun 2, 2016

Looks good @dhylands. Thanks for the PR, new package version in the works.

@canndrew canndrew merged commit 29e3460 into maidsafe-archive:master Jun 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants