Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAID-3278: Convert accomplice malice to provable #221

Merged
merged 3 commits into from Dec 20, 2018

Conversation

Projects
None yet
4 participants
@octol
Copy link
Contributor

octol commented Dec 17, 2018

Now that we have plugged the accomplice framing loop hole in MAID-3273, we can upgrade accomplice malice to provable.

@octol octol added the WIP label Dec 17, 2018

@octol octol changed the title Convert accomplice malice to provable MAID-3278: Convert accomplice malice to provable Dec 18, 2018

@octol octol force-pushed the octol:feat/convert-accomplice-to-provable branch from 4f78b8e to 982ec64 Dec 18, 2018

octol added some commits Dec 13, 2018

feat/parsec: convert accomplice malice to provable
Now that we have plugged the accomplice framing loop hole in MAID-3273,
we can upgrade accomplice malice to provable.
chore/parsec: remove chunked adding of events
With the new approach of having a candidate container of accomplice
accusations, chunked adding of events is no longer necessary.

@octol octol force-pushed the octol:feat/convert-accomplice-to-provable branch from 982ec64 to 4e77ab5 Dec 19, 2018

@octol octol removed the WIP label Dec 19, 2018

@octol octol requested review from madadam and Fraser999 Dec 19, 2018

@madadam
Copy link
Contributor

madadam left a comment

Code-wise looks good. I trust you (and the tests 😏 ) that the high-level logic is good, because I'm not entirely in the loop on it.

@pierrechevalier83 pierrechevalier83 merged commit 49d2eff into maidsafe:master Dec 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

madadam added a commit to madadam/parsec that referenced this pull request Dec 21, 2018

madadam added a commit to madadam/parsec that referenced this pull request Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.