From 59dfa09a34c7f2835401a6096dcf6c77eebc3fc5 Mon Sep 17 00:00:00 2001
From: Ian Coleman <ian@iancoleman.io>
Date: Mon, 29 Mar 2021 10:11:20 +1100
Subject: [PATCH] feat: add peer address to connection log messages

---
 src/connections.rs | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/src/connections.rs b/src/connections.rs
index 35642652..cbfb93f7 100644
--- a/src/connections.rs
+++ b/src/connections.rs
@@ -210,11 +210,11 @@ async fn read_on_uni_streams(
     while let Some(result) = uni_streams.next().await {
         match result {
             Err(quinn::ConnectionError::ApplicationClosed { .. }) => {
-                trace!("Connection terminated by peer.");
+                trace!("Connection terminated by peer {:?}.", peer_addr);
                 break;
             }
             Err(err) => {
-                warn!("Failed to read incoming message on uni-stream: {}", err);
+                warn!("Failed to read incoming message on uni-stream for peer {:?} with error: {}", peer_addr, err);
                 break;
             }
             Ok(mut recv) => loop {
@@ -225,7 +225,7 @@ async fn read_on_uni_streams(
                     Ok(msg) => error!("Unexpected message type: {:?}", msg),
                     Err(Error::StreamRead(quinn::ReadExactError::FinishedEarly)) => break,
                     Err(err) => {
-                        error!("Failed reading from a uni-stream: {}", err);
+                        error!("Failed reading from a uni-stream for peer {:?} with error: {}", peer_addr, err);
                         break;
                     }
                 }
@@ -243,11 +243,11 @@ async fn read_on_bi_streams(
     while let Some(result) = bi_streams.next().await {
         match result {
             Err(quinn::ConnectionError::ApplicationClosed { .. }) => {
-                trace!("Connection terminated by peer.");
+                trace!("Connection terminated by peer {:?}.", peer_addr);
                 break;
             }
             Err(err) => {
-                warn!("Failed to read incoming message on bi-stream: {}", err);
+                warn!("Failed to read incoming message on bi-stream for peer {:?} with error: {}", peer_addr, err);
                 break;
             }
             Ok((mut send, mut recv)) => loop {
@@ -257,7 +257,7 @@ async fn read_on_bi_streams(
                     }
                     Ok(WireMsg::EndpointEchoReq) => {
                         if let Err(error) = handle_endpoint_echo_req(peer_addr, &mut send).await {
-                            error!("Failed to handle Echo Request: {}", error);
+                            error!("Failed to handle Echo Request for peer {:?} with error: {}", peer_addr, error);
                         }
                     }
                     Ok(WireMsg::EndpointVerificationReq(address_sent)) => {
@@ -265,15 +265,15 @@ async fn read_on_bi_streams(
                             handle_endpoint_verification_req(peer_addr, address_sent, &mut send)
                                 .await
                         {
-                            error!("Failed to handle Endpoint verification request: {}", error);
+                            error!("Failed to handle Endpoint verification request for peer {:?} with error: {}", peer_addr, error);
                         }
                     }
                     Ok(msg) => {
-                        error!("Unexpected message type: {:?}", msg);
+                        error!("Unexpected message type from peer {:?}: {:?}", peer_addr, msg);
                     }
                     Err(Error::StreamRead(quinn::ReadExactError::FinishedEarly)) => break,
                     Err(err) => {
-                        error!("Failed reading from a bi-stream: {}", err);
+                        error!("Failed reading from a bi-stream for peer {:?} with error: {}", peer_addr, err);
                         break;
                     }
                 }
@@ -286,10 +286,10 @@ async fn handle_endpoint_echo_req(
     peer_addr: SocketAddr,
     send_stream: &mut quinn::SendStream,
 ) -> Result<()> {
-    trace!("Received Echo Request");
+    trace!("Received Echo Request from peer {:?}", peer_addr);
     let message = WireMsg::EndpointEchoResp(peer_addr);
     message.write_to_stream(send_stream).await?;
-    trace!("Responded to Echo request");
+    trace!("Responded to Echo request from peer {:?}", peer_addr);
     Ok(())
 }
 
@@ -324,7 +324,7 @@ async fn handle_endpoint_verification_req(
 
     let message = WireMsg::EndpointVerificationResp(verified);
     message.write_to_stream(send_stream).await?;
-    trace!("Responded to Endpoint verification request");
+    trace!("Responded to Endpoint verification request from {:?}", peer_addr);
 
     Ok(())
 }