Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #24 - Bootstrap and misc #34

Merged
merged 5 commits into from Apr 19, 2019

Conversation

Projects
None yet
2 participants
@ustulation
Copy link
Member

commented Apr 18, 2019

See individual commit

ustulation added some commits Apr 18, 2019

have a connection terminator
Have a facility to pre-maturely cancel ongoing connection futures
in-case they are no longer necessary/needed. This will be helpful for
bootstrapping for e.g., where one would want to parallely bootstrap and
cancel all attempts when anyone succeeds.
use QConn wrapper
This makes sure we have RAII for destroying quinn::Connection instead of tracking it in many places in code making it error prone. The upstream behaviour is that it will only call close if there are no references to the connection such as existing unresolved IncomingStreams etc. which is very error prone to track in our case and we want the connection gone on forgetting our handle which is the Connection object with Context. Thus RAII makes code far simpler and, more importantly, robust in our case.
.peers()
.iter()
.rev()
.chain(c.bootstrap_cache.hard_coded_contacts().iter())

This comment has been minimized.

Copy link
@povilasb

povilasb Apr 19, 2019

Contributor

Note that this will attempt to connect to hard coded contacts in parallel with the cached nodes. In case of success, I believe we'd like to postpone connection to hard coded contacts when connection to all cached nodes fails.

@ustulation

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2019

@ustulation ustulation merged commit fe16998 into maidsafe:master Apr 19, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details

@ustulation ustulation referenced this pull request Apr 19, 2019

Closed

Bootstrap API #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.