Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle key and certificate parse errors #56

Merged
merged 1 commit into from Jun 20, 2019

Conversation

Projects
None yet
2 participants
@d1vyank
Copy link
Contributor

commented Jun 20, 2019

Addresses a TODO to handle an error from parsing key material

@d1vyank d1vyank requested a review from ustulation as a code owner Jun 20, 2019

@ustulation

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

This was marked TODO because it could be read from the disk which could contain invalid stuff which will cause an error. Although I'm not clear if panicking is unwarranted in these situations as it's really user's fault to have put something invalid in the config and since that's the start-up scenario we should bail out as a hard error, I'm still inclined to accept this and pass the buck to the user library to deal with it. Maybe they want to fallback to something else on error etc.

So thanks for the PR; going to merge it now !

@ustulation ustulation merged commit 2528b15 into maidsafe:master Jun 20, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.