Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix: handle key and certificate parse errors #56
This was marked TODO because it could be read from the disk which could contain invalid stuff which will cause an error. Although I'm not clear if panicking is unwarranted in these situations as it's really user's fault to have put something invalid in the config and since that's the start-up scenario we should bail out as a hard error, I'm still inclined to accept this and pass the buck to the user library to deal with it. Maybe they want to fallback to something else on error etc.
So thanks for the PR; going to merge it now !