Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable standard lints and fix resulting issues #57

Merged
merged 4 commits into from Jun 21, 2019

Conversation

Projects
None yet
3 participants
@d1vyank
Copy link
Contributor

commented Jun 21, 2019

Adds standard lint rules used by the routing and parsec crates.

Fixes #55

@d1vyank d1vyank requested a review from ustulation as a code owner Jun 21, 2019

@nbaksalyar
Copy link
Member

left a comment

Thank you! One minor comment from me.

.travis.yml Outdated
@@ -18,7 +18,7 @@ before_script:
script:
- cargo fmt -- --check

This comment has been minimized.

Copy link
@nbaksalyar

nbaksalyar Jun 21, 2019

Member

I think this line can be removed now because it's included in scripts/clippy? And in that case it's probably better to rename this script because it also does the formatting.

Alternatively, it can be removed from scripts/clippy :)

This comment has been minimized.

Copy link
@d1vyank

d1vyank Jun 21, 2019

Author Contributor

Done, took the first suggestion!

@d1vyank d1vyank force-pushed the d1vyank:master branch from a1d86ae to 5f5b36b Jun 21, 2019

@nbaksalyar
Copy link
Member

left a comment

Thanks! 👍

@ustulation ustulation merged commit d3715ff into maidsafe:master Jun 21, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.