Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RFC0060 - Enable creating and modifying of FilesContainers with… #353

Open
wants to merge 8 commits into
base: master
from

Conversation

@SAFEShane
Copy link

SAFEShane commented Feb 11, 2020

…in the SAFE Browser environment

…in the SAFE Browser environment
@SAFEShane SAFEShane requested a review from maidsafe/developers as a code owner Feb 11, 2020
@SAFEShane

This comment has been minimized.

Copy link
Author

SAFEShane commented Feb 11, 2020

Please note that merging of this is pending discussion in the following SAFE forum topic: https://safenetforum.org/t/enable-creating-and-modifying-of-filescontainers-within-the-safe-browser-environment/31088, I'll update this PR with another comment once discussion has ceased.

@SAFEShane

This comment has been minimized.

Copy link
Author

SAFEShane commented Feb 18, 2020

After discussion we have also decided to add a type field to the files_container_add_from_raw. This PR is now in a mergeable state and can be considered by the Maidsafe team for inclusion.

.gitignore Outdated
@@ -1,3 +1,4 @@
*.sublime-project
*.sublime-workspace
*.swp
.idea

This comment has been minimized.

Copy link
@iancoleman

iancoleman Feb 18, 2020

Contributor

Should this (and other personal dev tools things already in .gitignore) be moved out of this repository? Typically these would belong in a .gitignore_global file. In git this is the configuration option called excludesfile.

https://intellij-support.jetbrains.com/hc/en-us/community/posts/115000154070-How-to-gitignore-idea-files?page=1#community_comment_115000258150

This comment has been minimized.

Copy link
@SAFEShane

SAFEShane Feb 18, 2020

Author

Hi Ian, I've removed this entry. You're quite right, it was just a reflex action for me to add it. I've left the others in there for now as I don't want to break anyone else's flow - it seems out of scope for this RFC, but I'd be happy to sponsor another pull request removing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.