Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove bls_emu and use real BLS #1906
Remove bls_emu: tweak quorum test as threshold in bls_emu was off by 1 in some cases (did not do the saturating_sub like Parsec and mock Parsec.
Some things still need some work (see commit comments), but it provide a reasonable baseline for further work.
This is the initial replacement, some issue remain: - Needs clean up - Security for messages is not really guarantee as any node can overwrite previous share by specifying invalid idx. (could do that already). - Combining Parsec signatures is a bit messy as it requires going through the elder_info to find position of all PublicIds for each signature. Note: - messages_accumulate_with_quorum was failing because bls_emu threshold was different from the on used in Parsec & mock Parsec. Update the test to match Parsec threshold. Test: Clippy + soak tests.
I'm looking at how to address the other comment, but the right way to do it (i.e I think keep the index with the secret key share is bigger than I would want for this PR).
@madadam is it ok to fix the not yet fixed comment in another PR so we can merge this since it has gone through soak test?