Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat\routing: export mock quic-p2p for vault use #1927

Merged

Conversation

@maqi
Copy link
Member

maqi commented Nov 29, 2019

This contains the work of export mock quick-p2p for vault use

pub struct Config {
/// Hard-coded contacts.
#[structopt(

This comment has been minimized.

Copy link
@jeanphilippeD

jeanphilippeD Nov 29, 2019

Contributor

is that because the real quic_p2p has this?

This comment has been minimized.

Copy link
@maqi

maqi Nov 29, 2019

Author Member

just because the vault code heavily use it. :(

This comment has been minimized.

Copy link
@octol

octol Nov 29, 2019

Contributor

Yep I ran into the same conundrum. I wonder if it's possible to wrap these structs to avoid structopt in routing? I suspect structop might cause a bit of build time overhead?

@maqi maqi requested review from jeanphilippeD and octol Nov 29, 2019
Copy link
Contributor

jeanphilippeD left a comment

Looks good to me, can you rebase and we can merge it.

@maqi maqi force-pushed the maqi:vault_issue_895_quic-p2p_replace branch from c557580 to 0472a95 Dec 3, 2019
@octol
octol approved these changes Dec 3, 2019
@jeanphilippeD jeanphilippeD merged commit 882cf37 into maidsafe:fleming Dec 3, 2019
15 of 16 checks passed
15 of 16 checks passed
Check (ubuntu-latest)
Details
Test (ubuntu-latest)
Details
Test (windows-latest) Test (windows-latest)
Details
Check (windows-latest)
Details
Check (macOS-latest)
Details
Test (macOS-latest)
Details
Test (ubuntu-latest, --release --features mock)
Details
Test (ubuntu-latest, --release)
Details
Test (windows-latest, --release --features mock)
Details
Test (windows-latest, --release)
Details
Test (macOS-latest, --release --features mock)
Details
Test (macOS-latest, --release)
Details
Rustfmt
Details
Clippy
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.