This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
Don't suppress parsec prune when relocation is in progress #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanphilippeD
previously approved these changes
Jan 7, 2020
octol
previously approved these changes
Jan 7, 2020
Instead any unaccumulated/unconsensused `Relocate` and `RelocatePrepare` votes are carried over to the new parsec instance.
madadam
force-pushed
the
dont-suppress-prune-for-relocation
branch
from
01dc0b8
to
94413c7
Compare
jeanphilippeD
approved these changes
Jan 7, 2020
jeanphilippeD
pushed a commit
to jeanphilippeD/routing
that referenced
this pull request
Jan 9, 2020
Fix aggressive_churn: [1221425541, 378878981, 107272102, 3204539950] at dc2abe1. Address issue introduced with maidsafe#1993: Ensure we filter out all completed events. Also improve logs for debuging. Test: Verify the seed is fixed. soak test + clippy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1963 .
Also includes a tiny refactoring.