Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't suppress parsec prune when relocation is in progress #1993

Merged

Conversation

@madadam
Copy link
Contributor

madadam commented Jan 7, 2020

Closes #1963 .

Also includes a tiny refactoring.

@madadam madadam requested review from jeanphilippeD and octol Jan 7, 2020
Copy link
Contributor

jeanphilippeD left a comment

Looks good. need soak testing.

madadam added 2 commits Jan 7, 2020
Instead any unaccumulated/unconsensused `Relocate` and `RelocatePrepare` votes are carried over to the new parsec instance.
@madadam madadam dismissed stale reviews from octol and jeanphilippeD via 94413c7 Jan 7, 2020
@madadam madadam force-pushed the madadam:dont-suppress-prune-for-relocation branch from 01dc0b8 to 94413c7 Jan 7, 2020
@jeanphilippeD jeanphilippeD merged commit d60e251 into maidsafe:fleming Jan 7, 2020
7 checks passed
7 checks passed
Rustfmt-Clippy
Details
TestRealParsec (ubuntu-latest)
Details
TestRealParsec (windows-latest)
Details
TestRealParsec (macOS-latest)
Details
Test (ubuntu-latest)
Details
Test (windows-latest)
Details
Test (macOS-latest)
Details
@madadam madadam deleted the madadam:dont-suppress-prune-for-relocation branch Jan 7, 2020
jeanphilippeD added a commit to jeanphilippeD/routing that referenced this pull request Jan 9, 2020
Fix aggressive_churn: [1221425541, 378878981, 107272102, 3204539950] at
dc2abe1.

Address issue introduced with maidsafe#1993: Ensure we filter out all completed
events.
Also improve logs for debuging.

Test:
Verify the seed is fixed.
soak test + clippy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.