Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/ffi: move error codes to FFI Error #296

Merged
merged 3 commits into from Oct 30, 2019

Conversation

@m-cat
Copy link
Contributor

m-cat commented Oct 23, 2019

This PR provides a nicer separation of concerns than previously. Now FFI-specific error codes do not appear outside the ffi module. The organization of the code is also simplified with respect to the Native and FFI error types.

Resolves #291

@m-cat m-cat requested a review from bochaco as a code owner Oct 23, 2019
Copy link
Member

bochaco left a comment

Awesome @m-cat

@bochaco

This comment has been minimized.

Copy link
Member

bochaco commented Oct 29, 2019

There is a problem on CLI tests on Mac that will need to be taken care of @m-cat

@m-cat m-cat force-pushed the m-cat:refactor-ffi-error branch from 9cfd79d to da7eec6 Oct 29, 2019
@bochaco bochaco force-pushed the m-cat:refactor-ffi-error branch from 5f6550f to f3da8d1 Oct 29, 2019
@m-cat m-cat force-pushed the m-cat:refactor-ffi-error branch from f3da8d1 to e0cc768 Oct 29, 2019
@bochaco bochaco merged commit 7be1a21 into maidsafe:master Oct 30, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.