Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/AuthorizationPopup: Handle invalid container names #133

Merged
merged 3 commits into from Apr 25, 2019

Conversation

Projects
3 participants
@ashwinkumar6
Copy link
Member

commented Apr 16, 2019

Fixes #128

@ashwinkumar6 ashwinkumar6 requested a review from ravinderjangra Apr 16, 2019

@ashwinkumar6 ashwinkumar6 requested a review from krishnaIndia as a code owner Apr 16, 2019

@ashwinkumar6 ashwinkumar6 added this to Done in Maintenance via automation Apr 16, 2019

@ashwinkumar6 ashwinkumar6 reopened this Apr 16, 2019

Maintenance automation moved this from Done to Reviewer approved Apr 17, 2019

Maintenance automation moved this from Reviewer approved to Needs review Apr 23, 2019

@ashwinkumar6 ashwinkumar6 force-pushed the ashwinkumar6:Issue-128 branch from 2669cb3 to 4bab2f8 Apr 23, 2019

@ashwinkumar6 ashwinkumar6 requested a review from ravinderjangra Apr 23, 2019

refactor/SafeAuth: refactor code
- Use container names from Constants class
- Update exception message

@ashwinkumar6 ashwinkumar6 force-pushed the ashwinkumar6:Issue-128 branch from 4bab2f8 to da9d1f9 Apr 24, 2019

@ashwinkumar6 ashwinkumar6 requested a review from ravinderjangra Apr 24, 2019

Maintenance automation moved this from Needs review to Reviewer approved Apr 24, 2019

@krishnaIndia krishnaIndia merged commit a785c97 into maidsafe:master Apr 25, 2019

1 check passed

SafeAuthenticator #20190424.3 succeeded
Details

Maintenance automation moved this from Reviewer approved to Done Apr 25, 2019

@ashwinkumar6 ashwinkumar6 deleted the ashwinkumar6:Issue-128 branch May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.