Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate native libs for safe-cli and WIP bindings #248

Merged
merged 34 commits into from Sep 26, 2019

Conversation

@ravinderjangra
Copy link
Member

commented Sep 18, 2019

Needs to be updated later

build.rs Outdated Show resolved Hide resolved
@@ -7,6 +7,9 @@
// permissions and limitations relating to use of the SAFE Network Software.

use std::fmt;
use ffi_utils::{ErrorCode, StringError};
use std::ffi::NulError;

This comment has been minimized.

Copy link
@bochaco

bochaco Sep 18, 2019

Member

We shouldn't be adding any FFI dependency from any file which is not in ffi folder

};
format!("[Error] {} - {}", error_type, error_msg)
}

#[allow(missing_docs)]
mod codes {

This comment has been minimized.

Copy link
@bochaco

bochaco Sep 18, 2019

Member

I'm not sure we need these codes in Rust API, perhaps only in FFI API? if so I think this should go in e.g. ffi/errors.rs file and not here, this is not needed by any Rust developer using this crate therefore it shouldn't be here.

src/api/keys.rs Outdated Show resolved Hide resolved
src/api/keys.rs Outdated Show resolved Hide resolved
src/subcommands/wallet.rs Outdated Show resolved Hide resolved
src/api/mod.rs Show resolved Hide resolved
src/ffi/keys.rs Outdated Show resolved Hide resolved
src/ffi/keys.rs Outdated Show resolved Hide resolved
src/ffi/wallet.rs Outdated Show resolved Hide resolved
build.rs Show resolved Hide resolved
src/api/xorurl.rs Outdated Show resolved Hide resolved
@bochaco bochaco force-pushed the ravinderjangra:bindings branch 3 times, most recently from 8254e3e to 8d3db59 Sep 20, 2019
@bochaco bochaco force-pushed the ravinderjangra:bindings branch from a354777 to 0c18b58 Sep 20, 2019
@bochaco bochaco force-pushed the ravinderjangra:bindings branch 2 times, most recently from d43913e to 9fda110 Sep 23, 2019
@bochaco bochaco marked this pull request as ready for review Sep 26, 2019
@bochaco

This comment has been minimized.

Copy link
Member

commented Sep 26, 2019

This is a fantastic job here @ravinderjangra ! really good stuff, it seems this PR puts us in a very nice position to start exposing the API to other languages.

@bochaco bochaco force-pushed the ravinderjangra:bindings branch from 17e8e0f to 23c219e Sep 26, 2019
@bochaco bochaco merged commit dccace4 into maidsafe:master Sep 26, 2019
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Pull Request Build Failed
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.