Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat/keys: add `Keypair` and remove bls methods for full IDs #123
This was referenced
Nov 1, 2019
We've already done this in `safe_vault`, now trying it here. This change was prompted by a false positive in the `clippy::type_repetition_in_bounds` lint. See https://hackmd.io/8odS50_AQV6U1wCHBfbeuw for the motivation. - Removed all `forbid` items: most are already `deny` by the compiler, not clear what explicitly forbidding them gives us. - `unsafe_code` stayed `deny`, other `deny` items removed as they are all `warn` and will be caught by CI. The `bad_style` lint was deprecated in favor of `nonstandard_style`, which is also `warn`. - Existing `warn` items mostly unchanged, except that a couple were added. These are all `allow` by the compiler, but useful to get warnings about. - Removed all `allow` items: they are already `allow` by the compiler.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.