Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solution to use multi-target #75

Merged
merged 20 commits into from Sep 6, 2019

Conversation

@ravinderjangra
Copy link
Member

commented Aug 30, 2019

Changes:

  • Move test projects to the Tests directory
  • Convert SafeApp.AppBindings and SafeApp.MockAuthBindings to use multi-target
  • Update .nuspec file
  • Update cake script to support new project structure

Note:

  • CI build may fail as it'll require some changes

@ravinderjangra ravinderjangra force-pushed the ravinderjangra:multi-target-again branch from 96c6f94 to dab4705 Sep 3, 2019

@ravinderjangra ravinderjangra requested a review from vigneshwara044 Sep 3, 2019

@ravinderjangra ravinderjangra marked this pull request as ready for review Sep 3, 2019

@ravinderjangra

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

If CI fails then I will create a new CI pipeline for this branch

@ravinderjangra

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2019

closing and reopening to run AzureDevOps CI

vNext automation moved this from In progress to Done Sep 3, 2019

@ravinderjangra ravinderjangra reopened this Sep 3, 2019

vNext automation moved this from Done to In progress Sep 3, 2019

@ravinderjangra ravinderjangra requested a review from oetyng Sep 4, 2019

@ravinderjangra

This comment has been minimized.

@oetyng oetyng self-requested a review Sep 6, 2019

@oetyng
oetyng approved these changes Sep 6, 2019

vNext automation moved this from In progress to Reviewer approved Sep 6, 2019

@ravinderjangra ravinderjangra merged commit fba54f1 into maidsafe:vNext Sep 6, 2019

1 of 2 checks passed

SafeApp-vNext-Mobile-CI #832 failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

vNext automation moved this from Reviewer approved to Done Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.