New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically reject authorisation request which mockbit doesn't match #454

Open
bochaco opened this Issue Dec 5, 2018 · 1 comment

Comments

@bochaco
Copy link
Member

bochaco commented Dec 5, 2018

For the scenarios when the browser is running for mock network, and an application sends an authorisation request which is for live network (or the other way around), the authenticator should be rejecting the authorisation automatically and sending such a response to the application. Currently the application doesn't receive any type of response.

@bochaco bochaco added the enhancement label Dec 5, 2018

@bochaco bochaco added this to Needs triage in Upcoming release ('master' branch) via automation Dec 5, 2018

@bochaco bochaco moved this from Needs triage to High priority in Upcoming release ('master' branch) Dec 18, 2018

@hunterlester hunterlester moved this from High priority to In Progress in Upcoming release ('master' branch) Jan 4, 2019

@hunterlester hunterlester self-assigned this Jan 4, 2019

@hunterlester hunterlester added this to the next milestone Jan 4, 2019

@hunterlester hunterlester moved this from In Progress to High priority in Upcoming release ('master' branch) Jan 4, 2019

@hunterlester hunterlester removed their assignment Jan 9, 2019

@hunterlester hunterlester moved this from High priority to In Progress in Upcoming release ('master' branch) Jan 17, 2019

@hunterlester hunterlester self-assigned this Jan 17, 2019

@joshuef joshuef modified the milestones: 0.11.1, Next Jan 17, 2019

@hunterlester hunterlester moved this from In Progress to High priority in Upcoming release ('master' branch) Jan 21, 2019

@hunterlester hunterlester removed their assignment Jan 21, 2019

@hunterlester hunterlester moved this from High priority to In Progress in Upcoming release ('master' branch) Jan 21, 2019

@hunterlester hunterlester self-assigned this Jan 21, 2019

@bochaco

This comment has been minimized.

Copy link
Member Author

bochaco commented Jan 22, 2019

@hunterlester , I'm not sure if the implemetation you are working on for this issue would also cover the case when the request sent is an old base64 encoded auth URI (i.e. generated by a safe_app lib prior to v0.9.0)? would in this case also be ignored by the authenticator and we can also send a propoer response to the app rejecting the auth?

@hunterlester hunterlester moved this from In Progress to Needs review in Upcoming release ('master' branch) Jan 24, 2019

@joshuef joshuef moved this from Needs review to In Progress in Upcoming release ('master' branch) Feb 19, 2019

@hunterlester hunterlester moved this from In Progress to Needs review in Upcoming release ('master' branch) Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment