Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX browser package has around 4 crust config files with various names in multiple locations #497

Closed
bochaco opened this Issue Dec 26, 2018 · 4 comments

Comments

4 participants
@bochaco
Copy link
Member

bochaco commented Dec 26, 2018

The following is extracted from a discussion in our forum: https://forum.safedev.org/t/trying-to-build-a-global-network/2266/19:
"SAFE Browser release packages needs better resource bundling. Currently browser package has around 4 crust config files with various names in multiple locations thereby needing other means to identify the valid config file. Should really be pruning dev config files/… before release packaging."

I just checked v0.11.0 linux package and I can see only two, still, the one at resources folder shoouldn't be needed in the package

$ find . -type f -iname "*crust.config"
./safe-browser-v0.11.0-linux-x64/safe-browser.crust.config
./safe-browser-v0.11.0-linux-x64/resources/SAFE Browser.crust.config

@bochaco bochaco added the enhancement label Dec 26, 2018

@bochaco bochaco added this to Needs triage in Upcoming release ('master' branch) via automation Dec 26, 2018

@bochaco bochaco changed the title Browser package has around 4 crust config files with various names in multiple locations OSX browser package has around 4 crust config files with various names in multiple locations Dec 26, 2018

@Viv-Rajkumar

This comment has been minimized.

Copy link
Member

Viv-Rajkumar commented Dec 27, 2018

In OSX, the latest release non-dev has a few more:

./SAFE Browser.app/Contents/safe-browser.crust.config
./SAFE Browser.app/Contents/Resources/SAFE Browser.crust.config
./SAFE Browser.app/Contents/SAFE Browser.crust.config
./SAFE Browser.app/Contents/Frameworks/SAFE Browser Helper.app/Contents/MacOS/SAFE Browser Helper.crust.config

@joshuef joshuef moved this from Needs triage to High priority in Upcoming release ('master' branch) Jan 28, 2019

@joshuef joshuef moved this from High priority to In Progress in Upcoming release ('master' branch) Feb 26, 2019

@joshuef joshuef added the 0.11.3 label Mar 1, 2019

@joshuef

This comment has been minimized.

Copy link
Collaborator

joshuef commented Mar 1, 2019

This is sorted on master after single package / ts refctors.

QA: in a folder with the release on macOs run find . -name "*crust*"

There should be only one.

@joshuef joshuef closed this Mar 1, 2019

Upcoming release ('master' branch) automation moved this from In Progress to Ready For QA Mar 1, 2019

@safesurfer

This comment has been minimized.

Copy link
Contributor

safesurfer commented Mar 7, 2019

Tested by building package on OSX (VM), the release folder contains only one crust.config file at this location ./SAFE Browser.app/Contents/Frameworks/SAFE Browser Helper.app/Contents/MacOS/SAFE Browser Helper.crust.config.

@safesurfer

This comment has been minimized.

Copy link
Contributor

safesurfer commented Mar 7, 2019

QA verified

@safesurfer safesurfer moved this from Ready For QA to Done in Upcoming release ('master' branch) Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.