Skip to content

/safe_client_libs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand support for Client keys to Ed25519 and BlsShare as well #1053

Closed
lionel1704 opened this issue Oct 30, 2019 · 1 comment
Closed

Expand support for Client keys to Ed25519 and BlsShare as well #1053

lionel1704 opened this issue Oct 30, 2019 · 1 comment
Assignees
@m-cat
Labels
enhancement
Projects
SAFE Client Libs - vNext

Comments

@lionel1704
Copy link
Member

@lionel1704 lionel1704 commented Oct 30, 2019 •
edited by m-cat

Currently safe_vault expects a PublicKey to identify a client. This public key is an enum which supports Bls, Ed25519 and BlsShare types. However, in SAFE Client Libs we support only the Bls type. We should extend the SCL API to support any of the 3 key types.

  • Add SecretKey enum to safe-nd similar to PublicKey. (maidsafe/safe-nd#123)
  • Replace occurances of BlsPublicKey and BlsSecretKey with the PublicKey and SecretKey enums in the structs and function parameters.
@lionel1704 lionel1704 added this to Needs triage in SAFE Client Libs - vNext via automation Oct 30, 2019
@lionel1704 lionel1704 moved this from Needs triage to High Priority in SAFE Client Libs - vNext Oct 30, 2019
@m-cat m-cat self-assigned this Oct 30, 2019
@lionel1704

This comment has been minimized.

Sign in to view
Copy link
Member Author

@lionel1704 lionel1704 commented Nov 26, 2019

Superseeded by #1060 that was resolved in #1058
@lionel1704 lionel1704 closed this Nov 26, 2019
SAFE Client Libs - vNext automation moved this from High Priority to Closed Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m-cat m-cat

Labels
enhancement
Projects
SAFE Client Libs - vNext
  
Closed
Milestone
No milestone
2 participants
@lionel1704 @m-cat
You can’t perform that action at this time.