Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate signing away from rust-sodium #1093

Merged
merged 1 commit into from Nov 29, 2019

Conversation

@lionel1704
Copy link
Member

lionel1704 commented Nov 25, 2019

closes #1079

@lionel1704 lionel1704 requested review from m-cat and Yoga07 Nov 25, 2019
@lionel1704 lionel1704 requested a review from nbaksalyar as a code owner Nov 25, 2019
@lionel1704 lionel1704 force-pushed the lionel1704:migrate-sign branch 3 times, most recently from ac6c134 to d57269a Nov 26, 2019
safe_app/src/tests/append_only_data.rs Show resolved Hide resolved
safe_app/src/object_cache.rs Outdated Show resolved Hide resolved
safe_authenticator/src/client.rs Outdated Show resolved Hide resolved
safe_core/src/client/account.rs Outdated Show resolved Hide resolved
safe_core/src/client/account.rs Show resolved Hide resolved
safe_core/src/utils/seed.rs Outdated Show resolved Hide resolved
@lionel1704 lionel1704 force-pushed the lionel1704:migrate-sign branch 2 times, most recently from 42640f4 to 145e29d Nov 28, 2019
@lionel1704 lionel1704 force-pushed the lionel1704:migrate-sign branch from 145e29d to b7eefc1 Nov 28, 2019
@m-cat
m-cat approved these changes Nov 28, 2019
Copy link
Contributor

m-cat left a comment

Looks great! Noticed something minor, feel free to ignore it.

@@ -80,7 +79,8 @@ impl AuthClient {
where {

This comment has been minimized.

Copy link
@m-cat

m-cat Nov 28, 2019

Contributor

Can we remove this where? I'm surprised the compiler doesn't complain about it 😄

This comment has been minimized.

Copy link
@lionel1704

lionel1704 Nov 29, 2019

Author Member

I'll sneak this change in a different PR :)

@lionel1704 lionel1704 merged commit 067f76c into maidsafe:master Nov 29, 2019
8 of 9 checks passed
8 of 9 checks passed
Rustfmt-Clippy
Details
build-android (armv7-linux-androideabi, prod)
Details
build-android (armv7-linux-androideabi, dev)
Details
build-android (x86_64-linux-android, prod)
Details
build-android (x86_64-linux-android, dev)
Details
Test (ubuntu-latest)
Details
Test (windows-latest)
Details
Travis CI - Pull Request Build Failed
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@lionel1704 lionel1704 deleted the lionel1704:migrate-sign branch Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.