Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace rust-sodium functions for symmetric encryption and key generation #1096

Merged
merged 3 commits into from Dec 2, 2019

Conversation

@lionel1704
Copy link
Member

lionel1704 commented Nov 28, 2019

  • Replace the use of symmetric encryption methods from rust-sodium with
    miscreant.
  • Use pbkdf2 for key generation
  • This PR also updates the deploy github action to make the deployed artifacts publicly readable.
@lionel1704 lionel1704 requested review from m-cat and Yoga07 Nov 28, 2019
@lionel1704 lionel1704 requested a review from nbaksalyar as a code owner Nov 28, 2019
@lionel1704 lionel1704 force-pushed the lionel1704:migrate-symm-encryption branch from cb52006 to 17b2c50 Nov 28, 2019
@lionel1704 lionel1704 changed the title Replace rust-sodium::secretbox with miscreant Replace rust-sodium functions for symmetric encryption and key generation Nov 28, 2019
safe_core/Cargo.toml Outdated Show resolved Hide resolved
safe_core/src/utils/mod.rs Outdated Show resolved Hide resolved
safe_core/src/ipc/resp.rs Outdated Show resolved Hide resolved
safe_core/src/client/account.rs Show resolved Hide resolved
@lionel1704 lionel1704 force-pushed the lionel1704:migrate-symm-encryption branch from 17b2c50 to 4785ffe Dec 2, 2019
@lionel1704 lionel1704 requested a review from m-cat Dec 2, 2019
@m-cat
m-cat approved these changes Dec 2, 2019
@lionel1704 lionel1704 merged commit 7e44e78 into maidsafe:master Dec 2, 2019
8 of 9 checks passed
8 of 9 checks passed
Rustfmt-Clippy
Details
build-android (armv7-linux-androideabi, prod)
Details
build-android (armv7-linux-androideabi, dev)
Details
build-android (x86_64-linux-android, prod)
Details
build-android (x86_64-linux-android, dev)
Details
Test (ubuntu-latest)
Details
Test (windows-latest)
Details
Travis CI - Pull Request Build Failed
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@lionel1704 lionel1704 deleted the lionel1704:migrate-symm-encryption branch Dec 2, 2019
@m-cat

This comment has been minimized.

Copy link
Contributor

m-cat commented Dec 2, 2019

Just noticed one thing, I'm getting these build errors:

error[E0599]: no method named `to_java` found for type `[u8; 16]` in the current scope
   --> safe_authenticator_jni/src/../../bindings/java/safe_authenticator/jni.rs:578:31
    |
578 |         let jobj = self.nonce.to_java(env)?;
    |                               ^^^^^^^ method not found in `[u8; 16]`
    |
    = help: items from traits can only be used if the trait is implemented and in scope
    = note: the following trait defines an item `to_java`, perhaps you need to implement it:
            candidate #1: `ToJava`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.