Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests in safe_core::client::mock #1106

Merged
merged 4 commits into from Dec 12, 2019
Merged

Conversation

@lionel1704
Copy link
Member

lionel1704 commented Dec 6, 2019

@m-cat this PR is a work in progress to re-enable the tests in the safe_core::client::mock.

I have refactored the helper functions used for the tests and re-enabled a single test. Let me know what you think about this approach. If it's okay, then I can proceed with refactoring the other tests as well using the same pattern. Thanks!

EDIT: PR is now ready for review

@lionel1704 lionel1704 requested a review from m-cat Dec 6, 2019
@lionel1704 lionel1704 requested a review from nbaksalyar as a code owner Dec 6, 2019
@lionel1704 lionel1704 force-pushed the lionel1704:mock-tests branch from 83e938b to e424896 Dec 10, 2019
- refactor test framework in the mock network module of safe_core
- enable a single test to demonstrate the use of the new approach
@lionel1704 lionel1704 force-pushed the lionel1704:mock-tests branch from e424896 to e4f16e5 Dec 10, 2019
@lionel1704 lionel1704 requested a review from Yoga07 Dec 10, 2019
@lionel1704 lionel1704 changed the title WIP: Enable tests in safe_core::client::mock Enable tests in safe_core::client::mock Dec 10, 2019
@lionel1704 lionel1704 force-pushed the lionel1704:mock-tests branch from e4f16e5 to 10f8d18 Dec 10, 2019
@lionel1704 lionel1704 requested a review from Yoga07 Dec 10, 2019
safe_core/src/client/mock/tests.rs Outdated Show resolved Hide resolved
safe_core/src/client/mock/tests.rs Show resolved Hide resolved
safe_core/src/client/mock/tests.rs Outdated Show resolved Hide resolved
safe_core/src/client/mock/tests.rs Outdated Show resolved Hide resolved
safe_core/src/client/mock/tests.rs Show resolved Hide resolved
- refactor the setup() function to create an account and return the
safe-key and owner key instead of the client full id
@m-cat
m-cat approved these changes Dec 11, 2019
Copy link
Contributor

m-cat left a comment

Awesome!

@Yoga07
Yoga07 approved these changes Dec 12, 2019
Copy link
Member

Yoga07 left a comment

Nice one! 👍

@lionel1704 lionel1704 merged commit 4b1f455 into maidsafe:master Dec 12, 2019
13 of 14 checks passed
13 of 14 checks passed
Rustfmt-Clippy
Details
Build Scripts
Details
build-ios (aarch64-apple-ios) build-ios (aarch64-apple-ios)
Details
build-ios (x86_64-apple-ios) build-ios (x86_64-apple-ios)
Details
build-android (armv7-linux-androideabi, prod)
Details
build-android (armv7-linux-androideabi, dev)
Details
build-android (x86_64-linux-android, prod)
Details
build-android (x86_64-linux-android, dev)
Details
Test (ubuntu-latest)
Details
Test (windows-latest)
Details
Test (macOS-latest)
Details
Build iOS Universal (prod)
Details
Build iOS Universal (dev)
Details
Travis CI - Pull Request Build Errored
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.