Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Client store chunk performance #247

Closed
maqi opened this issue May 8, 2023 · 0 comments · Fixed by #269
Closed

Improve Client store chunk performance #247

maqi opened this issue May 8, 2023 · 0 comments · Fixed by #269

Comments

@maqi
Copy link
Member

maqi commented May 8, 2023

Current, when a client storing a chunk, it first get closest peers, send send out request to each and wait on all ALL responses (Ok or non-Ok) till complete and return.
This will make the flow slow when connection to one of the nodes is in problem, i.e. a response only got returned after TimeOut.

The performance can be improved by using the similar function as to expect_closest_majority_ok with the dbc spend flow, which will erturn earlier whenever received majority OK responses.
OR even being more agressive to return on the first OK response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant