Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (13)
@maqi maqi Apr 21, 2023
line break for the TODO point
Outdated
safenode/src/domain/storage/spends.rs
oetyng
@maqi maqi Apr 21, 2023
o querying -> by querying ?
Outdated
safenode/src/domain/storage/spends.rs
oetyng
@maqi maqi Apr 21, 2023
I do think here we shall fail the whole (remove the whole path, if there is per path for each log? otherwise to remove all created cmd_files?) in case of having ANY of error?
safenode/src/domain/storage/registers/mod.rs
oetyng
@maqi maqi Apr 21, 2023
will `file not find` be counted as an error? As I understand, it shall not?
safenode/src/domain/storage/registers/mod.rs
oetyng
@maqi maqi Apr 21, 2023
it's not filename but NoFileInDir ?
Outdated
safenode/src/domain/storage/error.rs
oetyng
@maqi maqi Apr 21, 2023
better specify `lowercase` or `uppercase`
safenode/src/domain/storage/chunks/mod.rs
maqi oetyng
@maqi maqi Apr 21, 2023
better use XOR_NAME_LEN instead of 32. btw. would like to confirm that the filename of a chunk is in hex, which will be 2*XOR_NAME_LEN , and it will be ok to be parsed here, right?
Outdated
safenode/src/domain/storage/chunks/mod.rs
oetyng
@maqi maqi Apr 21, 2023
hmm... I feel it's bit confusing now, both `id()` and `name()` returns with `XorName` I can understand that `id` is `hash(name+tag)` to be unique probably not expose `name()` (to avoid mis-use) or to make `id()` type safe or give `name()` a more explicit naming, say `service_name` or `content_name` or etc?
...de/src/domain/storage/address/register.rs
oetyng
@maqi maqi Apr 21, 2023
is the unwrap then wrap necessary? same to the belows
safenode/src/domain/node_transfers/mod.rs
oetyng
@RolandSherwin RolandSherwin Apr 21, 2023
Can we make this function available everywhere by removing the `cfg` flag? This might be useful during the data replication flow.
safenode/src/domain/storage/registers/mod.rs
oetyng
@oetyng oetyng Apr 21, 2023
Fixing this `Chunk` in comment.
safenode/src/domain/storage/spends.rs
@oetyng oetyng Apr 21, 2023
Adding comments here to clarify when this is to be used.
safenode/src/domain/storage/chunks/mod.rs
@oetyng oetyng Apr 21, 2023
Fixing this old comment.
Outdated
safenode/src/domain/storage/chunks/mod.rs