Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent concurrent dials #255

Merged
merged 2 commits into from May 10, 2023

Conversation

joshuef
Copy link
Contributor

@joshuef joshuef commented May 10, 2023

No description provided.

@reviewpad
Copy link

reviewpad bot commented May 10, 2023

AI-Generated Summary: This pull request introduces a fix to prevent concurrent dials in the safenode network implementation. The changes involve modifying the SwarmDriver implementation to immediately update the pending_dial hashmap when launching a new dial, as dials can take time and may cause conflicts if not managed properly. Additionally, error handling has been improved by informing the user of any dial errors encountered during the process.

@reviewpad reviewpad bot requested a review from RolandSherwin May 10, 2023 00:17
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels May 10, 2023
@reviewpad
Copy link

reviewpad bot commented May 10, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

‼️ Errors

  • Unconventional commit detected: 'Move log to make sense when adding peer to routing table' (1d992f3)

@reviewpad
Copy link

reviewpad bot commented May 10, 2023

AI-Generated Summary: This pull request consists of two patches that aim to improve the network handling in a SafeNode application. The first patch fixes an issue of preventing concurrent dials by updating the pending dial hashmap immediately and handling dial errors properly. The second patch moves a log statement about adding a peer to the routing table to a more appropriate location in the event handling logic.

@b-zee b-zee added this pull request to the merge queue May 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2023
@joshuef joshuef added this pull request to the merge queue May 10, 2023
Merged via the queue into maidsafe:main with commit 4ac76b7 May 10, 2023
18 checks passed
@joshuef joshuef deleted the FixPreventConcurrentDials branch May 10, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants